linux-kernel - RE: [PATCH 7/6] x86: __always_inline _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jan 2021 10:31:31 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Peter Zijlstra' <peterz@...radead.org>,
        Randy Dunlap <rdunlap@...radead.org>
CC:     "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jpoimboe@...hat.com" <jpoimboe@...hat.com>,
        "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
        "tony.luck@...el.com" <tony.luck@...el.com>
Subject: RE: [PATCH 7/6] x86: __always_inline __{rd,wr}msr()

From: Peter Zijlstra
> Sent: 07 January 2021 10:18
...
> -static inline unsigned long long notrace __rdmsr(unsigned int msr)
> +static __always_inline unsigned long long __rdmsr(unsigned int msr)

Since we (should) only request 'inline' for things that need to be
inlined, maybe inline should expand to __attribute__((always_inline)).

That might throw up a few warnings where inline has been misused.
But they are less problematic than things not being inlined.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)