linux-kernel - Re: [PATCH -next] media: zoran: use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210107104557.GA5083@kadam>
Date:   Thu, 7 Jan 2021 13:45:57 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     LABBE Corentin <clabbe@...libre.com>
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org,
        Zheng Yongjun <zhengyongjun3@...wei.com>,
        mjpeg-users@...ts.sourceforge.net, mchehab@...nel.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH -next] media: zoran: use resource_size

On Wed, Jan 06, 2021 at 09:19:58PM +0100, LABBE Corentin wrote:
> Le Wed, Jan 06, 2021 at 05:51:00PM +0300, Dan Carpenter a écrit :
> > On Wed, Jan 06, 2021 at 09:17:02PM +0800, Zheng Yongjun wrote:
> > > Use resource_size rather than a verbose computation on
> > > the end and start fields.
> > > 
> > > Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> > > ---
> > >  drivers/staging/media/zoran/zoran_driver.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
> > > index 808196ea5b81..d60b4c73ea80 100644
> > > --- a/drivers/staging/media/zoran/zoran_driver.c
> > > +++ b/drivers/staging/media/zoran/zoran_driver.c
> > > @@ -1020,7 +1020,7 @@ int zoran_queue_init(struct zoran *zr, struct vb2_queue *vq)
> > >  	vq->buf_struct_size = sizeof(struct zr_buffer);
> > >  	vq->ops = &zr_video_qops;
> > >  	vq->mem_ops = &vb2_dma_contig_memops;
> > > -	vq->gfp_flags = GFP_DMA32,
> > > +	vq->gfp_flags = GFP_DMA32;
> > 
> > The commit doesn't match the patch.  Also this driver is in
> > staging because it's going to be deleted soon so there probably isn't
> > much point doing cleanups.
> > 
> 
> No, the driver just came back in staging since I fixed the videobuf2 conversion.

Ah... Thanks.

regards,
dan carpenter