linux-kernel - Re: [PATCH] tracing/kprobes: Do the notrace functions check without kprobes on ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210107091330.3782789c@gandalf.local.home>
Date:   Thu, 7 Jan 2021 09:13:30 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     "Naveen N . Rao" <naveen.n.rao@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing/kprobes: Do the notrace functions check without
 kprobes on ftrace

On Wed,  6 Jan 2021 12:20:40 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> Enable the notrace function check on the architecture which doesn't
> support kprobes on ftrace. This notrace function check is not only
> for the kprobes on ftrace but also sw-breakpoint based kprobes.
> Thus there is no reason to limit this check for the arch which
> supports kprobes on ftrace.
> 
> This also changes the dependency of Kconfig. Because kprobe event
> uses the function tracer's address list for identifying notrace
> function, if the CONFIG_FUNCTION_TRACER=n, it can not check whether
> the target function is notrace or not.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
> Acked-by: Naveen N. Rao <naveen.n.rao@...ux.vnet.ibm.com>
> ---

Fails to build with:

kernel/trace/trace_kprobe.c: In function ‘__within_notrace_func’:
kernel/trace/trace_kprobe.c:453:10: error: implicit declaration of function ‘ftrace_location_range’; did you mean ‘ftrace_location’? [-Werror=implicit-function-declaration]
  453 |  return !ftrace_location_range(addr, addr + size - 1);
      |          ^~~~~~~~~~~~~~~~~~~~~
      |          ftrace_location

Config attached.

-- Steve

Download attachment "config" of type "application/octet-stream" (126250 bytes)