linux-kernel - [PATCH 5.4 01/13] Revert "drm/amd/display: Fix memory leaks in S3 resume"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210107143050.100326268@linuxfoundation.org>
Date:   Thu,  7 Jan 2021 15:33:20 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, Stylon Wang <stylon.wang@....com>,
        Harry Wentland <harry.wentland@....com>,
        Nicholas Kazlauskas <nicholas.kazlauskas@....com>,
        Andre Tomt <andre@...t.net>,
        Oleksandr Natalenko <oleksandr@...alenko.name>,
        Alex Deucher <alexander.deucher@....com>
Subject: [PATCH 5.4 01/13] Revert "drm/amd/display: Fix memory leaks in S3 resume"

From: Alex Deucher <alexdeucher@...il.com>

This reverts commit a135a1b4c4db1f3b8cbed9676a40ede39feb3362.

This leads to blank screens on some boards after replugging a
display.  Revert until we understand the root cause and can
fix both the leak and the blank screen after replug.

Cc: Stylon Wang <stylon.wang@....com>
Cc: Harry Wentland <harry.wentland@....com>
Cc: Nicholas Kazlauskas <nicholas.kazlauskas@....com>
Cc: Andre Tomt <andre@...t.net>
Cc: Oleksandr Natalenko <oleksandr@...alenko.name>
Signed-off-by: Alex Deucher <alexander.deucher@....com>
Cc: stable@...r.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -1434,8 +1434,7 @@ amdgpu_dm_update_connector_after_detect(
 
 			drm_connector_update_edid_property(connector,
 							   aconnector->edid);
-			aconnector->num_modes = drm_add_edid_modes(connector, aconnector->edid);
-			drm_connector_list_update(connector);
+			drm_add_edid_modes(connector, aconnector->edid);
 
 			if (aconnector->dc_link->aux_mode)
 				drm_dp_cec_set_edid(&aconnector->dm_dp_aux.aux,