linux-kernel - Re: [PATCH] software_node: Add kernel-doc comments to exported symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2e0ca2e5-feaa-bd3b-c680-0ad7c7c2d651@gmail.com>
Date:   Thu, 7 Jan 2021 14:45:33 +0000
From:   Daniel Scally <djrscally@...il.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org, rafael@...nel.org,
        gregkh@...uxfoundation.org, sakari.ailus@...ux.intel.com
Subject: Re: [PATCH] software_node: Add kernel-doc comments to exported
 symbols

Hi Heikki

On 07/01/2021 14:19, Heikki Krogerus wrote:
> On Tue, Jan 05, 2021 at 03:39:42PM +0000, Daniel Scally wrote:
>> Hi Andy
>>
>> On 05/01/2021 14:53, Andy Shevchenko wrote:
>>> On Mon, Jan 04, 2021 at 11:47:36PM +0000, Daniel Scally wrote:
>>>> A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any
>>>> kernel-doc comments; add those in so all exported symbols are documented.
>>> Thanks, it's helpful!
>>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>> after addressing few nitpicks
>> Thanks for reviewing
>>>> Signed-off-by: Daniel Scally <djrscally@...il.com>
>>>> ---
>>>> With a view to maybe writing some documentation once the fwnode_graph_*()
>>>> functions are also added.
>>> FWIW, Heikki used to have a draft patch of swnode documentation, not sure
>>> what's the current status of it.
>> Oh cool ok; I'll defer to him then.
> I actually had a similar patch prepared as part of the series adding
> the documentation for software nodes, but your comments are better
> than mine. So, after you have addressed Andy's comments:
>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Great, thanks - and for the other R-bs just now also. I'll send a v2 of
this one tonight/tomorrow (depends how much else I get through)