linux-kernel - Re: [PATCH] Hyper-V: pci: x64: Generalize irq/msi set-up and handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210107150216.GA1365474@bjorn-Precision-5520>
Date:   Thu, 7 Jan 2021 09:02:16 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Sunil Muthuswamy <sunilmut@...rosoft.com>
Cc:     KY Srinivasan <kys@...rosoft.com>,
        Boqun Feng <Boqun.Feng@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <liuwe@...rosoft.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        "\"H. Peter Anvin\"" <hpa@...or.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] Hyper-V: pci: x64: Generalize irq/msi set-up and handling

There seems to be a long tradition of dreaming up random formats for
the subject lines of Hyper-V-related patches.  Look at all the
different ways these are spelled, hyphenated, and capitalized:

  $ git log --oneline arch/x86/include/asm/mshyperv.h
  626b901f6044 ("Drivers: hv: vmbus: Add parsing of VMbus interrupt in ACPI DSDT")
  b9d8cf2eb3ce ("x86/hyperv: Make hv_setup_sched_clock inline")
  a16be368dd3f ("x86/entry: Convert various hypervisor vectors to IDTENTRY_SYSVEC")
  2ddddd0b4e89 ("Drivers: hv: Move AEOI determination to architecture dependent code")
  1cf106d93245 ("PCI: hv: Introduce hv_msi_entry")
  b95a8a27c300 ("x86/vdso: Use generic VDSO clock mode storage")
  eec399dd8627 ("x86/vdso: Move VDSO clocksource state tracking to callback")
  fa36dcdf8b20 ("x86: hv: Add function to allocate zeroed page for Hyper-V")
  8c3e44bde7fd ("x86/hyperv: Add functions to allocate/deallocate page for Hyper-V")
  765e33f5211a ("Drivers: hv: vmbus: Break out ISA independent parts of mshyperv.h")
  dd2cb348613b ("clocksource/drivers: Continue making Hyper-V clocksource ISA agnostic")
  cc4edae4b924 ("x86/hyper-v: Add HvFlushGuestAddressList hypercall support")
  b42967dcac1d ("x86/hyper-v: Fix indentation in hv_do_fast_hypercall16()")
  3a025de64bf8 ("x86/hyperv: Enable PV qspinlock for Hyper-V")
  eb914cfe72f4 ("X86/Hyper-V: Add flush HvFlushGuestPhysicalAddressSpace hypercall support")
  ...

On Thu, Jan 07, 2021 at 05:05:36AM +0000, Sunil Muthuswamy wrote:
> Currently, operations related to irq/msi in Hyper-V vPCI are

In comments in the patch, you use "IRQ" and "MSI".  I don't know
whether "vPCI" means something or is a typo.  I suppose it probably
means "virtual PCI" as below.

> x86-specific code. In order to support virtual PCI on Hyper-V for
> other architectures, introduce generic interfaces to replace the
> x86-specific ones. There are no functional changes in this patch.
>
> Signed-off-by: Sunil Muthuswamy <sunilmut@...rosoft.com>
> Signed-off-by: Boqun Feng (Microsoft) <boqun.feng@...il.com>
> ...