linux-kernel - Re: [PATCH v6 5/6] crypto: hisilicon/hpre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202101072354.jdZNn7em-lkp@intel.com>
Date:   Thu, 7 Jan 2021 23:10:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     Meng Yu <yumeng18@...wei.com>, herbert@...dor.apana.org.au,
        davem@...emloft.net
Cc:     kbuild-all@...ts.01.org, linux-crypto@...r.kernel.org,
        xuzaibo@...wei.com, wangzhou1@...ilicon.com, yumeng18@...wei.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 5/6] crypto: hisilicon/hpre - add 'ECDH' algorithm

Hi Meng,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on cryptodev/master]
[also build test WARNING on crypto/master v5.11-rc2 next-20210104]
[cannot apply to sparc-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Meng-Yu/add-ECDH-and-CURVE25519-algorithms-support-for-Kunpeng-930/20210107-201957
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/3516f267a2983fb736a244a7b21d2ef9937e4046
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Meng-Yu/add-ECDH-and-CURVE25519-algorithms-support-for-Kunpeng-930/20210107-201957
        git checkout 3516f267a2983fb736a244a7b21d2ef9937e4046
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/crypto/hisilicon/hpre/hpre_crypto.c:1208:6: warning: no previous prototype for 'fill_curve_param' [-Wmissing-prototypes]
    1208 | void fill_curve_param(void *addr, u64 *param, unsigned int cur_sz, u8 ndigits)
         |      ^~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for FRAME_POINTER
   Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS
   Selected by
   - FAULT_INJECTION_STACKTRACE_FILTER && FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT && !X86_64 && !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86


vim +/fill_curve_param +1208 drivers/crypto/hisilicon/hpre/hpre_crypto.c

  1207	
> 1208	void fill_curve_param(void *addr, u64 *param, unsigned int cur_sz, u8 ndigits)
  1209	{
  1210		unsigned int sz = cur_sz - (ndigits - 1) * sizeof(u64);
  1211		u8 i = 0;
  1212	
  1213		while (i < ndigits - 1) {
  1214			memcpy(addr + sizeof(u64) * i, &param[i], sizeof(u64));
  1215			i++;
  1216		}
  1217	
  1218		memcpy(addr + sizeof(u64) * i, &param[ndigits - 1], sz);
  1219		hpre_key_to_big_end((u8 *)addr, cur_sz);
  1220	}
  1221	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (63479 bytes)