linux-kernel - Re: scsi: Add diagnostic log for scsi device reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3770e4f3025e48759ad64513a457f1276031d900.camel@linux.ibm.com>
Date:   Thu, 07 Jan 2021 08:49:07 -0800
From:   James Bottomley <jejb@...ux.ibm.com>
To:     lijinlin <lijinlin3@...wei.com>, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, martin.petersen@...cle.com
Cc:     linfeilong@...wei.com, liuzhiqiang26@...wei.com
Subject: Re: scsi: Add diagnostic log for scsi device reset

On Thu, 2021-01-07 at 19:43 +0800, lijinlin wrote:
[...]
> -		SCSI_LOG_ERROR_RECOVERY(3,
> +		if (bdr_scmd->request && bdr_scmd->request->rq_disk)
>  			sdev_printk(KERN_INFO, sdev,
> -				     "%s: Sending BDR\n", current-
> >comm));
> +				     "[%s] Sending device reset\n",
> +				     bdr_scmd->request->rq_disk-
> >disk_name);

Not everything is a SCSI disk.  If we apply this patch, we lose traces
for any non-disk device that get reset ... for tapes this can be really
important to know.

James