linux-kernel - Re: [PATCH v2 1/2] ACPI: platform-profile: Introduce object pointers to callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jan 2021 18:11:07 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Mark Gross <mgross@...ux.intel.com>,
        Ike Panhc <ike.pan@...onical.com>,
        Mark Pearson <markpearson@...ovo.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] ACPI: platform-profile: Introduce object pointers
 to callbacks

On Tue, Jan 5, 2021 at 2:18 PM Hans de Goede <hdegoede@...hat.com> wrote:
>
> Hi,
>
> On 1/5/21 2:14 PM, Jiaxun Yang wrote:
> > Add a object pointer to handler callbacks to avoid having
> > global variables everywhere.
> >
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@...goat.com>
> > Suggested-by: Hans de Goede <hdegoede@...hat.com>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
>
> Regards,
>
> Hans
>
>
>
> > ---
> >  drivers/acpi/platform_profile.c  | 4 ++--
> >  include/linux/platform_profile.h | 6 ++++--
> >  2 files changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> > index 91be50a32cc8..bb4d7b0fe2ac 100644
> > --- a/drivers/acpi/platform_profile.c
> > +++ b/drivers/acpi/platform_profile.c
> > @@ -64,7 +64,7 @@ static ssize_t platform_profile_show(struct device *dev,
> >               return -ENODEV;
> >       }
> >
> > -     err = cur_profile->profile_get(&profile);
> > +     err = cur_profile->profile_get(cur_profile, &profile);
> >       mutex_unlock(&profile_lock);
> >       if (err)
> >               return err;
> > @@ -104,7 +104,7 @@ static ssize_t platform_profile_store(struct device *dev,
> >               return -EOPNOTSUPP;
> >       }
> >
> > -     err = cur_profile->profile_set(i);
> > +     err = cur_profile->profile_set(cur_profile, i);
> >       mutex_unlock(&profile_lock);
> >       if (err)
> >               return err;
> > diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h
> > index 3623d7108421..43f4583b5259 100644
> > --- a/include/linux/platform_profile.h
> > +++ b/include/linux/platform_profile.h
> > @@ -28,8 +28,10 @@ enum platform_profile_option {
> >
> >  struct platform_profile_handler {
> >       unsigned long choices[BITS_TO_LONGS(PLATFORM_PROFILE_LAST)];
> > -     int (*profile_get)(enum platform_profile_option *profile);
> > -     int (*profile_set)(enum platform_profile_option profile);
> > +     int (*profile_get)(struct platform_profile_handler *pprof,
> > +                             enum platform_profile_option *profile);
> > +     int (*profile_set)(struct platform_profile_handler *pprof,
> > +                             enum platform_profile_option profile);
> >  };
> >
> >  int platform_profile_register(const struct platform_profile_handler *pprof);
> >
>

Applied with a modified subject and some edits in the changelog as
5.12 material, and I'm leaving the [2/2] to you.

Thanks!