linux-kernel - Re: [PATCH 12/15] regulator: Support ROHM BD71815 regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 9 Jan 2021 06:30:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Matti Vaittinen <mazziesaccount@...il.com>
Cc:     kbuild-all@...ts.01.org, Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Matti Vaittinen <mazziesaccount@...il.com>,
        linux-kernel@...r.kernel.org, linux-power@...rohmeurope.com
Subject: Re: [PATCH 12/15] regulator: Support ROHM BD71815 regulators

Hi Matti,

I love your patch! Perhaps something to improve:

[auto build test WARNING on lee-mfd/for-mfd-next]
[also build test WARNING on regulator/for-next abelloni/rtc-next v5.11-rc2 next-20210108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Matti-Vaittinen/Support-ROHM-BD71815-PMIC/20210108-215230
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: powerpc64-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c84f932f4232b680eb9cc134cf94999bfda0a948
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matti-Vaittinen/Support-ROHM-BD71815-PMIC/20210108-215230
        git checkout c84f932f4232b680eb9cc134cf94999bfda0a948
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/regulator/bd71815-regulator.c:592:5: warning: no previous prototype for 'bd7181x_probe' [-Wmissing-prototypes]
     592 | int bd7181x_probe(struct platform_device *pdev)
         |     ^~~~~~~~~~~~~


vim +/bd7181x_probe +592 drivers/regulator/bd71815-regulator.c

   591	
 > 592	int bd7181x_probe(struct platform_device *pdev)
   593	{
   594		struct bd71815_pmic *pmic;
   595		struct regulator_config config = {};
   596		int i, ret;
   597		struct gpio_desc *ldo4_en;
   598	
   599		pmic = devm_kzalloc(&pdev->dev, sizeof(*pmic), GFP_KERNEL);
   600		if (!pmic)
   601			return -ENOMEM;
   602	
   603		memcpy(pmic->descs, bd71815_regulators,	sizeof(pmic->descs));
   604	
   605		pmic->dev = &pdev->dev;
   606		pmic->regmap = dev_get_regmap(pdev->dev.parent, NULL);
   607		if (!pmic->regmap) {
   608			dev_err(pmic->dev, "No parent regmap\n");
   609			return -ENODEV;
   610		}
   611		platform_set_drvdata(pdev, pmic);
   612		ldo4_en = devm_gpiod_get_from_of_node(&pdev->dev,
   613						      pdev->dev.parent->of_node,
   614							 "rohm,vsel-gpios", 0,
   615							 GPIOD_ASIS, "ldo4-en");
   616	
   617		if (IS_ERR(ldo4_en)) {
   618			ret = PTR_ERR(ldo4_en);
   619			if (ret != -ENOENT)
   620				return ret;
   621			ldo4_en = NULL;
   622		}
   623	
   624		/* Disable to go to ship-mode */
   625		ret = regmap_update_bits(pmic->regmap, BD71815_REG_PWRCTRL, RESTARTEN, 0);
   626		if (ret)
   627			return ret;
   628	
   629		config.dev = pdev->dev.parent;
   630		config.regmap = pmic->regmap;
   631	
   632		for (i = 0; i < BD71815_REGULATOR_CNT; i++) {
   633			struct regulator_desc *desc;
   634			struct regulator_dev *rdev;
   635	
   636			desc = &pmic->descs[i].desc;
   637			if (i == BD71815_LDO4)
   638				config.ena_gpiod = ldo4_en;
   639	
   640			config.driver_data = pmic;
   641	
   642			rdev = devm_regulator_register(&pdev->dev, desc, &config);
   643			if (IS_ERR(rdev)) {
   644				dev_err(&pdev->dev,
   645					"failed to register %s regulator\n",
   646					desc->name);
   647				return PTR_ERR(rdev);
   648			}
   649			config.ena_gpiod = NULL;
   650			pmic->rdev[i] = rdev;
   651		}
   652		return 0;
   653	}
   654	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (71634 bytes)