lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 7 Jan 2021 20:03:49 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     menglong8.dong@...il.com, roopa@...dia.com
Cc:     nikolay@...dia.com, davem@...emloft.net, kuba@...nel.org,
        bridge@...ts.linux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Menglong Dong <dong.menglong@....com.cn>
Subject: Re: [PATCH net-next] net/bridge: fix misspellings using codespell
 tool

On 1/7/21 6:53 PM, menglong8.dong@...il.com wrote:
> From: Menglong Dong <dong.menglong@....com.cn>
> 
> Some typos are found out by codespell tool:
> 
> $ codespell ./net/bridge/
> ./net/bridge/br_stp.c:604: permanant  ==> permanent
> ./net/bridge/br_stp.c:605: persistance  ==> persistence
> ./net/bridge/br.c:125: underlaying  ==> underlying
> ./net/bridge/br_input.c:43: modue  ==> mode
> ./net/bridge/br_mrp.c:828: Determin  ==> Determine
> ./net/bridge/br_mrp.c:848: Determin  ==> Determine
> ./net/bridge/br_mrp.c:897: Determin  ==> Determine
> 
> Fix typos found by codespell.
> 
> Signed-off-by: Menglong Dong <dong.menglong@....com.cn>

LGTM. Thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org>

> ---
>  net/bridge/br.c       | 2 +-
>  net/bridge/br_input.c | 2 +-
>  net/bridge/br_mrp.c   | 6 +++---
>  net/bridge/br_stp.c   | 4 ++--
>  4 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/net/bridge/br.c b/net/bridge/br.c
> index 1b169f8e7491..ef743f94254d 100644
> --- a/net/bridge/br.c
> +++ b/net/bridge/br.c
> @@ -122,7 +122,7 @@ static int br_device_event(struct notifier_block *unused, unsigned long event, v
>  		break;
>  
>  	case NETDEV_PRE_TYPE_CHANGE:
> -		/* Forbid underlaying device to change its type. */
> +		/* Forbid underlying device to change its type. */
>  		return NOTIFY_BAD;
>  
>  	case NETDEV_RESEND_IGMP:
> diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
> index 8ca1f1bc6d12..222285d9dae2 100644
> --- a/net/bridge/br_input.c
> +++ b/net/bridge/br_input.c
> @@ -40,7 +40,7 @@ static int br_pass_frame_up(struct sk_buff *skb)
>  
>  	vg = br_vlan_group_rcu(br);
>  	/* Bridge is just like any other port.  Make sure the
> -	 * packet is allowed except in promisc modue when someone
> +	 * packet is allowed except in promisc mode when someone
>  	 * may be running packet capture.
>  	 */
>  	if (!(brdev->flags & IFF_PROMISC) &&
> diff --git a/net/bridge/br_mrp.c b/net/bridge/br_mrp.c
> index cec2c4e4561d..fc0a98874bfc 100644
> --- a/net/bridge/br_mrp.c
> +++ b/net/bridge/br_mrp.c
> @@ -825,7 +825,7 @@ int br_mrp_start_in_test(struct net_bridge *br,
>  	return 0;
>  }
>  
> -/* Determin if the frame type is a ring frame */
> +/* Determine if the frame type is a ring frame */
>  static bool br_mrp_ring_frame(struct sk_buff *skb)
>  {
>  	const struct br_mrp_tlv_hdr *hdr;
> @@ -845,7 +845,7 @@ static bool br_mrp_ring_frame(struct sk_buff *skb)
>  	return false;
>  }
>  
> -/* Determin if the frame type is an interconnect frame */
> +/* Determine if the frame type is an interconnect frame */
>  static bool br_mrp_in_frame(struct sk_buff *skb)
>  {
>  	const struct br_mrp_tlv_hdr *hdr;
> @@ -894,7 +894,7 @@ static void br_mrp_mrm_process(struct br_mrp *mrp, struct net_bridge_port *port,
>  		br_mrp_ring_port_open(port->dev, false);
>  }
>  
> -/* Determin if the test hdr has a better priority than the node */
> +/* Determine if the test hdr has a better priority than the node */
>  static bool br_mrp_test_better_than_own(struct br_mrp *mrp,
>  					struct net_bridge *br,
>  					const struct br_mrp_ring_test_hdr *hdr)
> diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
> index 3e88be7aa269..a3a5745660dd 100644
> --- a/net/bridge/br_stp.c
> +++ b/net/bridge/br_stp.c
> @@ -601,8 +601,8 @@ int __set_ageing_time(struct net_device *dev, unsigned long t)
>  /* Set time interval that dynamic forwarding entries live
>   * For pure software bridge, allow values outside the 802.1
>   * standard specification for special cases:
> - *  0 - entry never ages (all permanant)
> - *  1 - entry disappears (no persistance)
> + *  0 - entry never ages (all permanent)
> + *  1 - entry disappears (no persistence)
>   *
>   * Offloaded switch entries maybe more restrictive
>   */
> 


-- 
~Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://www.kernel.org/doc/html/latest/process/submit-checklist.html

Powered by blists - more mailing lists