linux-kernel - Re: [PATCH v2] driver core: Fix device link device name collision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ed3da70b825e4cbe778e9b8e4619434@walle.cc>
Date:   Fri, 08 Jan 2021 01:27:24 +0100
From:   Michael Walle <michael@...le.cc>
To:     Saravana Kannan <saravanak@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>, stable@...r.kernel.org,
        kernel-team@...roid.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] driver core: Fix device link device name collision

Am 2021-01-08 01:14, schrieb Michael Walle:
> Am 2021-01-08 00:41, schrieb Saravana Kannan:
>> The device link device's name was of the form:
>> <supplier-dev-name>--<consumer-dev-name>
>> 
>> This can cause name collision as reported here [1] as device names are
>> not globally unique. Since device names have to be unique within the
>> bus/class, add the bus/class name as a prefix to the device names used 
>> to
>> construct the device link device name.
>> 
>> So the devuce link device's name will be of the form:
>> <supplier-bus-name>:<supplier-dev-name>--<consumer-bus-name>:<consumer-dev-name>
>> 
>> [1] - 
>> https://lore.kernel.org/lkml/20201229033440.32142-1-michael@walle.cc/
>> 
>> Cc: stable@...r.kernel.org
>> Fixes: 287905e68dd2 ("driver core: Expose device link details in 
>> sysfs")
>> Reported-by: Michael Walle <michael@...le.cc>
>> Signed-off-by: Saravana Kannan <saravanak@...gle.com>
>> ---
> 
> This makes it even worse.

Mhh, actually there are now other errors (the ones before might be 
fixed). Seems
to be truncated filenames and for the iommu ones, I don't know.

-- 
-michael