linux-kernel - Re: [PATCH] ARM: dts: sun5i: add A10s/A13 display frontend support fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210108092248.c3pmjrextonnf33q@gilmour>
Date:   Fri, 8 Jan 2021 10:22:48 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Sergio Sota <sergiosota@...amoel.com>
Cc:     robh+dt@...nel.org, wens@...e.org, jernej.skrabec@...l.net,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: sun5i: add A10s/A13 display frontend support
 fallback

Hi,

On Thu, Jan 07, 2021 at 11:59:27AM +0100, Sergio Sota wrote:
> The A10s/A13 display frontend driver is not implemented
> Set A10 display frontend driver as a fallback for A10s/A13
> Tested with Olimex-A13-SOM / Olimex-A13-OlinuXino-MICRO
> "modetest -M sun4i-drm -s 49@47:800x480-60"  ( 7.0" tft lcd)
> "modetest -M sun4i-drm -s 49@47:1024x600-60" (10.1" tft lcd)
> 
> Signed-off-by: Sergio Sota <sergiosota@...amoel.com>
> ---

You should mention the version number (using -v in git send-email or
format-patch), and add a changelog here

>  arch/arm/boot/dts/sun5i.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi
> index c2b4fbf552a3..4ef14a8695ef 100644
> --- a/arch/arm/boot/dts/sun5i.dtsi
> +++ b/arch/arm/boot/dts/sun5i.dtsi
> @@ -734,7 +734,8 @@ timer@...0000 {
>  		};
>  
>  		fe0: display-frontend@...0000 {
> -			compatible = "allwinner,sun5i-a13-display-frontend";
> +			compatible = "allwinner,sun5i-a13-display-frontend",
> +				     "allwinner,sun4i-a10-display-frontend";

The comment on the first version still apply here, even more so with the
additional details you provided in the commit message

Maxime