linux-kernel - Re: [PATCH] mm,hwpoison: Fix printing of page flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1d4face-71a7-3526-bcdb-b48d41f32da4@arm.com>
Date:   Fri, 8 Jan 2021 14:59:12 +0530
From:   Anshuman Khandual <anshuman.khandual@....com>
To:     Oscar Salvador <osalvador@...e.de>, akpm@...ux-foundation.org
Cc:     n-horiguchi@...jp.nec.com, dan.carpenter@...cle.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm,hwpoison: Fix printing of page flags



On 1/8/21 2:22 PM, Oscar Salvador wrote:
> Format %pG expects a lower case 'p' in order to print the flags.
> Fix it.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Oscar Salvador <osalvador@...e.de>
> Fixes: 8295d535e2aa ("mm,hwpoison: refactor get_any_page")

Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>

> ---
>  mm/memory-failure.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 5a38e9eade94..04d9f154a130 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1940,7 +1940,7 @@ int soft_offline_page(unsigned long pfn, int flags)
>  			goto retry;
>  		}
>  	} else if (ret == -EIO) {
> -		pr_info("%s: %#lx: unknown page type: %lx (%pGP)\n",
> +		pr_info("%s: %#lx: unknown page type: %lx (%pGp)\n",
>  			 __func__, pfn, page->flags, &page->flags);
>  	}
>  
>