linux-kernel - Re: [PATCH v2] driver core: Fix device link device name collision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGETcx_CJjOxim+CEptLRSgfYAKHBbP8rHW7BY+U7-X+L2eObg@mail.gmail.com>
Date:   Thu, 7 Jan 2021 17:00:32 -0800
From:   Saravana Kannan <saravanak@...gle.com>
To:     Michael Walle <michael@...le.cc>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        stable <stable@...r.kernel.org>,
        Android Kernel Team <kernel-team@...roid.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] driver core: Fix device link device name collision

On Thu, Jan 7, 2021 at 4:43 PM Saravana Kannan <saravanak@...gle.com> wrote:
>
> On Thu, Jan 7, 2021 at 4:14 PM Michael Walle <michael@...le.cc> wrote:
> >
> > Am 2021-01-08 00:41, schrieb Saravana Kannan:
> > > The device link device's name was of the form:
> > > <supplier-dev-name>--<consumer-dev-name>
> > >
> > > This can cause name collision as reported here [1] as device names are
> > > not globally unique. Since device names have to be unique within the
> > > bus/class, add the bus/class name as a prefix to the device names used
> > > to
> > > construct the device link device name.
> > >
> > > So the devuce link device's name will be of the form:
> > > <supplier-bus-name>:<supplier-dev-name>--<consumer-bus-name>:<consumer-dev-name>
> > >
> > > [1] -
> > > https://lore.kernel.org/lkml/20201229033440.32142-1-michael@walle.cc/
> > >
> > > Cc: stable@...r.kernel.org
> > > Fixes: 287905e68dd2 ("driver core: Expose device link details in
> > > sysfs")
> > > Reported-by: Michael Walle <michael@...le.cc>
> > > Signed-off-by: Saravana Kannan <saravanak@...gle.com>
> > > ---
> >
> > This makes it even worse. Please see below for a full bootlog with the
> > dev_dbg() converted to dev_info() and initcall_debug enabled.
>
> Sorry if I'm missing something obvious (been a long day), but how is
> it worse? I don't see any warnings in this log. I'll reply to your
> other emails separately.
>

Nevermind, I see it now. Also, in the future, if you can dump the logs
in some kind of pastebin site, that'd be nice. Avoid the emails
becoming unwieldy and also avoids the log lines from wrapping.

-Saravana