linux-kernel - RE: [PATCH v3 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

Open Source and information security mailing list archives

Message-ID: <OSBPR01MB1991DBFA6C4BD6818947EF6BDDAE0@OSBPR01MB1991.jpnprd01.prod.outlook.com>
Date:   Fri, 8 Jan 2021 10:07:07 +0000
From:   HAGIO KAZUHITO(萩尾　一仁) 
        <k-hagio-ab@....com>
To:     Baoquan He <bhe@...hat.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "lijiang@...hat.com" <lijiang@...hat.com>,
        "kexec@...ts.infradead.org" <kexec@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ktkhai@...tuozzo.com" <ktkhai@...tuozzo.com>,
        "ebiederm@...ssion.com" <ebiederm@...ssion.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "dyoung@...hat.com" <dyoung@...hat.com>,
        "christian.brauner@...ntu.com" <christian.brauner@...ntu.com>,
        "vgoyal@...hat.com" <vgoyal@...hat.com>,
        "keescook@...omium.org" <keescook@...omium.org>,
        Alexander Egorenkov <egorenar@...ux.ibm.com>
Subject: RE: [PATCH v3 1/1] kdump: append uts_namespace.name offset to
 VMCOREINFO

Hi Baoquan,

-----Original Message-----
> On 09/30/20 at 12:23pm, Alexander Egorenkov wrote:
> > The offset of the field 'init_uts_ns.name' has changed
> > since commit 9a56493f6942 ("uts: Use generic ns_common::count").
> 
> This patch is merged into 5.11-rc1, but we met the makedumpfile failure
> of kdump test case in 5.10.0 kernel. Should affect 5.9 too since
> commit 9a56493f6942 is merged into 5.9-rc2.

Hmm, commit 9a56493f6942 should have been merged into 5.11-rc1
together with commit ca4a9241cc5e.

Does your makedumpfile have the following patch?
https://github.com/makedumpfile/makedumpfile/commit/54aec3878b3f91341e6bc735eda158cca5c54ec9

or am I missing something?

Thanks,
Kazu

> 
> Below tag and CC should have been added into patch when posted.
> 
> Fixes: commit 9a56493f6942 ("uts: Use generic ns_common::count")
> Cc: <stable@...r.kernel.org>
> 
> Hi Greg,
> 
> Do we still have chance to make it added into stable?
> 
> Thanks
> Baoquan
> 
> >
> > Link: https://lore.kernel.org/r/159644978167.604812.1773586504374412107.stgit@localhost.localdomain
> >
> > Make the offset of the field 'uts_namespace.name' available
> > in VMCOREINFO because tools like 'crash-utility' and
> > 'makedumpfile' must be able to read it from crash dumps.
> >
> > Signed-off-by: Alexander Egorenkov <egorenar@...ux.ibm.com>
> > ---
> >
> > v2 -> v3:
> >  * Added documentation to vmcoreinfo.rst
> >  * Use the short form of the commit reference
> >
> > v1 -> v2:
> >  * Improved commit message
> >  * Added link to the discussion of the uts namespace changes
> >
> >  Documentation/admin-guide/kdump/vmcoreinfo.rst | 6 ++++++
> >  kernel/crash_core.c                            | 1 +
> >  2 files changed, 7 insertions(+)
> >
> > diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst
> b/Documentation/admin-guide/kdump/vmcoreinfo.rst
> > index e44a6c01f336..3861a25faae1 100644
> > --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst
> > +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst
> > @@ -39,6 +39,12 @@ call.
> >  User-space tools can get the kernel name, host name, kernel release
> >  number, kernel version, architecture name and OS type from it.
> >
> > +(uts_namespace, name)
> > +---------------------
> > +
> > +Offset of the name's member. Crash Utility and Makedumpfile get
> > +the start address of the init_uts_ns.name from this.
> > +
> >  node_online_map
> >  ---------------
> >
> > diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> > index 106e4500fd53..173fdc261882 100644
> > --- a/kernel/crash_core.c
> > +++ b/kernel/crash_core.c
> > @@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)
> >  	VMCOREINFO_PAGESIZE(PAGE_SIZE);
> >
> >  	VMCOREINFO_SYMBOL(init_uts_ns);
> > +	VMCOREINFO_OFFSET(uts_namespace, name);
> >  	VMCOREINFO_SYMBOL(node_online_map);
> >  #ifdef CONFIG_MMU
> >  	VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir);
> > --
> > 2.26.2
> >
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives