linux-kernel - Re: [PATCH v2] misc: pvpanic: introduce device capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12aebc37-aaba-2ed2-d944-c80eeac6f052@redhat.com>
Date:   Fri, 8 Jan 2021 12:43:11 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        zhenwei pi <pizhenwei@...edance.com>
Cc:     arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] misc: pvpanic: introduce device capability

On 08/01/21 12:28, Greg KH wrote:
>>   static void __iomem *base;
>> +static unsigned int capability = PVPANIC_PANICKED | PVPANIC_CRASH_LOADED;
>> +module_param(capability, uint, 0444);
>> +MODULE_PARM_DESC(capability, "capability of pvpanic device");
> This is not the 1990's, please do not add new module parameters:(

Note that the parameter can also be used to _limit_ which capabilities 
the driver uses:

v1:

> +	/* initlize capability by RDPT */
> +	capability = ioread8(base);

v2:

> +	/* initlize capability by RDPT */
> +	capability &= ioread8(base);

Of course it would have helped if there was a summary of v1->v2 changes 
in the message. :)

Paolo

> Use sysfs, and properly document the file in Documentation/ABI/