linux-kernel - Re: [PATCH V2 9/9] arm64: dts: renesas: beacon: Increase sdhi speeds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXf9iXvoDHDvx0fjx1yQx=5-cjDz_pECDjrXZn__z4cFA@mail.gmail.com>
Date:   Fri, 8 Jan 2021 15:02:03 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Adam Ford <aford173@...il.com>
Cc:     Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Adam Ford-BE <aford@...conembedded.com>,
        Magnus Damm <magnus.damm@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 9/9] arm64: dts: renesas: beacon: Increase sdhi speeds

Hi Adam,

On Thu, Dec 24, 2020 at 6:05 PM Adam Ford <aford173@...il.com> wrote:
> The eMMC can run at hs400 and the WiFi chip can run at sdr104.
> Set the respective flags to push the sdhi faster.
>
> Signed-off-by: Adam Ford <aford173@...il.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi
> @@ -271,8 +271,9 @@ &scif2 {
>  };
>
>  &sdhi2 {
> -       pinctrl-names = "default";
>         pinctrl-0 = <&sdhi2_pins>;
> +       pinctrl-1 = <&sdhi2_pins>;
> +       pinctrl-names = "default", "state_uhs";
>         bus-width = <4>;
>         vmmc-supply = <&reg_3p3v>;
>         vqmmc-supply = <&reg_1p8v>;
> @@ -281,6 +282,8 @@ &sdhi2 {
>         pm-ignore-notify;
>         keep-power-in-suspend;
>         mmc-pwrseq = <&wlan_pwrseq>;
> +       sd-uhs-sdr50;
> +       sd-uhs-sdr104;
>         status = "okay";
>         #address-cells = <1>;
>         #size-cells = <0>;

The HS400 change was accidentally part of "[PATCH V2 5/9] arm64: dts:
renesas: beacon: Cleanup USB References":

| @@ -315,16 +306,12 @@ &sdhi3 {
|   vmmc-supply = <&reg_3p3v>;
|   vqmmc-supply = <&reg_1p8v>;
|   bus-width = <8>;
| - mmc-hs200-1_8v;
| + mmc-hs400-1_8v;
|   non-removable;
|   fixed-emmc-driver-type = <1>;
|   status = "okay";

You probably want to keep, not replace, the "mmc-hs200-1_8v" property,
though.

With that fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds