lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1610070485.1574.10.camel@mhfsdcap03> Date: Fri, 8 Jan 2021 09:48:05 +0800 From: Yongqiang Niu <yongqiang.niu@...iatek.com> To: CK Hu <ck.hu@...iatek.com>, Jassi Brar <jassisinghbrar@...il.com> CC: Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, "David Airlie" <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Mark Rutland <mark.rutland@....com>, <dri-devel@...ts.freedesktop.org>, <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>, <Project_Global_Chrome_Upstream_Group@...iatek.com>, Chun-Kuang Hu <chunkuang.hu@...nel.org>, <damon.chu@...iatek.com>, <dennis-yc.hsieh@...iatek.com> Subject: Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote: > Add address shift when compose jump instruction > to compatible with 35bit format. > > Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform") > > Signed-off-by: Yongqiang Niu <yongqiang.niu@...iatek.com> > Reviewed-by: Nicolas Boichat <drinkcat@...omium.org> > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index 5665b6e..75378e3 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -168,7 +168,8 @@ static void cmdq_task_insert_into_thread(struct cmdq_task *task) > dma_sync_single_for_cpu(dev, prev_task->pa_base, > prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE); > prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] = > - (u64)CMDQ_JUMP_BY_PA << 32 | task->pa_base; > + (u64)CMDQ_JUMP_BY_PA << 32 | > + (task->pa_base >> task->cmdq->shift_pa); > dma_sync_single_for_device(dev, prev_task->pa_base, > prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE); > hi jassi please confirm is there any question about this patch. if not, please apply this into next version, tks
Powered by blists - more mailing lists