linux-kernel - Re: [PATCH 24/40] drm/amd/display/dc/dce/dce_stream_encoder: Remove unused variable 'regval'

Open Source and information security mailing list archives

Message-ID: <CADnq5_NMmop3fFb3vy1QS_wEjNCmwkzjn+aTMd0S45GkKpiCpw@mail.gmail.com>
Date:   Fri, 8 Jan 2021 16:12:39 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Leo Li <sunpeng.li@....com>, LKML <linux-kernel@...r.kernel.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        David Airlie <airlied@...ux.ie>,
        Eric Bernstein <eric.bernstein@....com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        George Shen <george.shen@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH 24/40] drm/amd/display/dc/dce/dce_stream_encoder: Remove
 unused variable 'regval'

On Fri, Jan 8, 2021 at 3:15 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_stream_encoder.c: In function ‘dce110_update_generic_info_packet’:
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_stream_encoder.c:70:11: warning: variable ‘regval’ set but not used [-Wunused-but-set-variable]
>
> Cc: Harry Wentland <harry.wentland@....com>
> Cc: Leo Li <sunpeng.li@....com>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: "Christian König" <christian.koenig@....com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: George Shen <george.shen@....com>
> Cc: Eric Bernstein <eric.bernstein@....com>
> Cc: amd-gfx@...ts.freedesktop.org
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c b/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
> index ada57f745fd76..265eaef30a519 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
> @@ -67,7 +67,6 @@ static void dce110_update_generic_info_packet(
>         uint32_t packet_index,
>         const struct dc_info_packet *info_packet)
>  {
> -       uint32_t regval;
>         /* TODOFPGA Figure out a proper number for max_retries polling for lock
>          * use 50 for now.
>          */
> @@ -99,7 +98,7 @@ static void dce110_update_generic_info_packet(
>         }
>         /* choose which generic packet to use */
>         {
> -               regval = REG_READ(AFMT_VBI_PACKET_CONTROL);
> +               REG_READ(AFMT_VBI_PACKET_CONTROL);
>                 REG_UPDATE(AFMT_VBI_PACKET_CONTROL,
>                                 AFMT_GENERIC_INDEX, packet_index);
>         }
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives