linux-kernel - Re: [PATCH 31/40] drm/amd/display/dc/dce/dce_opp: Make local functions and ones invoked by reference static

Open Source and information security mailing list archives

Date:   Fri, 8 Jan 2021 16:19:39 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Leo Li <sunpeng.li@....com>, Mauro Rossi <issor.oruam@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        David Airlie <airlied@...ux.ie>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH 31/40] drm/amd/display/dc/dce/dce_opp: Make local
 functions and ones invoked by reference static

On Fri, Jan 8, 2021 at 3:15 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:427:6: warning: no previous prototype for ‘dce60_opp_set_clamping’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:548:6: warning: no previous prototype for ‘dce60_opp_program_bit_depth_reduction’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:571:6: warning: no previous prototype for ‘dce60_opp_program_clamping_and_pixel_encoding’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:681:6: warning: no previous prototype for ‘dce60_opp_program_fmt’ [-Wmissing-prototypes]
>
> Cc: Harry Wentland <harry.wentland@....com>
> Cc: Leo Li <sunpeng.li@....com>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: "Christian König" <christian.koenig@....com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Mauro Rossi <issor.oruam@...il.com>
> Cc: amd-gfx@...ts.freedesktop.org
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_opp.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c b/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c
> index e459ae65aaf76..2bf8f5a2e0c22 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c
> @@ -424,7 +424,7 @@ void dce110_opp_set_clamping(
>   *             7 for programable
>   *     2) Enable clamp if Limited range requested
>   */
> -void dce60_opp_set_clamping(
> +static void dce60_opp_set_clamping(
>         struct dce110_opp *opp110,
>         const struct clamping_and_pixel_encoding_params *params)
>  {
> @@ -545,7 +545,7 @@ void dce110_opp_program_bit_depth_reduction(
>  }
>
>  #if defined(CONFIG_DRM_AMD_DC_SI)
> -void dce60_opp_program_bit_depth_reduction(
> +static void dce60_opp_program_bit_depth_reduction(
>         struct output_pixel_processor *opp,
>         const struct bit_depth_reduction_params *params)
>  {
> @@ -568,7 +568,7 @@ void dce110_opp_program_clamping_and_pixel_encoding(
>  }
>
>  #if defined(CONFIG_DRM_AMD_DC_SI)
> -void dce60_opp_program_clamping_and_pixel_encoding(
> +static void dce60_opp_program_clamping_and_pixel_encoding(
>         struct output_pixel_processor *opp,
>         const struct clamping_and_pixel_encoding_params *params)
>  {
> @@ -678,7 +678,7 @@ void dce110_opp_program_fmt(
>  }
>
>  #if defined(CONFIG_DRM_AMD_DC_SI)
> -void dce60_opp_program_fmt(
> +static void dce60_opp_program_fmt(
>         struct output_pixel_processor *opp,
>         struct bit_depth_reduction_params *fmt_bit_depth,
>         struct clamping_and_pixel_encoding_params *clamping)
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives