linux-kernel - Re: [PATCH 37/40] drm/amd/display/dc/dce/dce_i2c_sw: Make a bunch of local functions static

Open Source and information security mailing list archives

Message-ID: <CADnq5_NHZ6V9R3P22vWNBmWtn0Xz840K-r8kxV-1dv=0UPSECQ@mail.gmail.com>
Date:   Fri, 8 Jan 2021 16:24:38 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Leo Li <sunpeng.li@....com>, LKML <linux-kernel@...r.kernel.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        David Airlie <airlied@...ux.ie>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH 37/40] drm/amd/display/dc/dce/dce_i2c_sw: Make a bunch of
 local functions static

On Fri, Jan 8, 2021 at 3:16 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_sw.c:342:6: warning: no previous prototype for ‘dce_i2c_sw_engine_set_speed’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_sw.c:356:6: warning: no previous prototype for ‘dce_i2c_sw_engine_acquire_engine’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_sw.c:400:6: warning: no previous prototype for ‘dce_i2c_sw_engine_submit_channel_request’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_sw.c:443:6: warning: no previous prototype for ‘dce_i2c_sw_engine_submit_payload’ [-Wmissing-prototypes]
>
> Cc: Harry Wentland <harry.wentland@....com>
> Cc: Leo Li <sunpeng.li@....com>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: "Christian König" <christian.koenig@....com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: amd-gfx@...ts.freedesktop.org
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c b/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c
> index 87d8428df6c46..6846afd83701b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c
> @@ -339,7 +339,7 @@ static bool start_sync_sw(
>         return false;
>  }
>
> -void dce_i2c_sw_engine_set_speed(
> +static void dce_i2c_sw_engine_set_speed(
>         struct dce_i2c_sw *engine,
>         uint32_t speed)
>  {
> @@ -353,7 +353,7 @@ void dce_i2c_sw_engine_set_speed(
>                 engine->clock_delay = 12;
>  }
>
> -bool dce_i2c_sw_engine_acquire_engine(
> +static bool dce_i2c_sw_engine_acquire_engine(
>         struct dce_i2c_sw *engine,
>         struct ddc *ddc)
>  {
> @@ -397,7 +397,7 @@ bool dce_i2c_engine_acquire_sw(
>
>
>
> -void dce_i2c_sw_engine_submit_channel_request(
> +static void dce_i2c_sw_engine_submit_channel_request(
>         struct dce_i2c_sw *engine,
>         struct i2c_request_transaction_data *req)
>  {
> @@ -440,7 +440,8 @@ void dce_i2c_sw_engine_submit_channel_request(
>                 I2C_CHANNEL_OPERATION_SUCCEEDED :
>                 I2C_CHANNEL_OPERATION_FAILED;
>  }
> -bool dce_i2c_sw_engine_submit_payload(
> +
> +static bool dce_i2c_sw_engine_submit_payload(
>         struct dce_i2c_sw *engine,
>         struct i2c_payload *payload,
>         bool middle_of_transaction)
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives