Message-ID: <CADnq5_OK7ApRm4EwuW6kqAdQ192N4GJ2bgEtgKjvO8qyKR4Meg@mail.gmail.com>
Date:   Fri, 8 Jan 2021 16:26:24 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Leo Li <sunpeng.li@....com>, LKML <linux-kernel@...r.kernel.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        David Airlie <airlied@...ux.ie>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>, Wyatt Wood <wyatt.wood@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH 39/40] drm/amd/display/dc/dce/dmub_psr: Demote
 non-conformant kernel-doc headers

On Fri, Jan 8, 2021 at 3:16 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:38: warning: Function parameter or member 'raw_state' not described in 'convert_psr_state'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:81: warning: Function parameter or member 'dmub' not described in 'dmub_psr_get_state'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:81: warning: Function parameter or member 'state' not described in 'dmub_psr_get_state'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:97: warning: Function parameter or member 'dmub' not described in 'dmub_psr_set_version'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:97: warning: Function parameter or member 'stream' not described in 'dmub_psr_set_version'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:128: warning: Function parameter or member 'dmub' not described in 'dmub_psr_enable'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:128: warning: Function parameter or member 'enable' not described in 'dmub_psr_enable'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:128: warning: Function parameter or member 'wait' not described in 'dmub_psr_enable'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:177: warning: Function parameter or member 'dmub' not described in 'dmub_psr_set_level'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:177: warning: Function parameter or member 'psr_level' not described in 'dmub_psr_set_level'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:203: warning: Function parameter or member 'dmub' not described in 'dmub_psr_copy_settings'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:203: warning: Function parameter or member 'link' not described in 'dmub_psr_copy_settings'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:203: warning: Function parameter or member 'psr_context' not described in 'dmub_psr_copy_settings'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:284: warning: Function parameter or member 'dmub' not described in 'dmub_psr_force_static'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:301: warning: Function parameter or member 'dmub' not described in 'dmub_psr_get_residency'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:301: warning: Function parameter or member 'residency' not described in 'dmub_psr_get_residency'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:323: warning: Function parameter or member 'psr' not described in 'dmub_psr_construct'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:323: warning: Function parameter or member 'ctx' not described in 'dmub_psr_construct'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:332: warning: Function parameter or member 'ctx' not described in 'dmub_psr_create'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:349: warning: Function parameter or member 'dmub' not described in 'dmub_psr_destroy'
>
> Cc: Harry Wentland <harry.wentland@....com>
> Cc: Leo Li <sunpeng.li@....com>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: "Christian König" <christian.koenig@....com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Wyatt Wood <wyatt.wood@....com>
> Cc: amd-gfx@...ts.freedesktop.org
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Applied.  Thanks!

Alex


> ---
>  drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 22 +++++++++----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c
> index 17e84f34ceba1..4228caa741193 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c
> @@ -31,7 +31,7 @@
>
>  #define MAX_PIPES 6
>
> -/**
> +/*
>   * Convert dmcub psr state to dmcu psr state.
>   */
>  static enum dc_psr_state convert_psr_state(uint32_t raw_state)
> @@ -74,7 +74,7 @@ static enum dc_psr_state convert_psr_state(uint32_t raw_state)
>         return state;
>  }
>
> -/**
> +/*
>   * Get PSR state from firmware.
>   */
>  static void dmub_psr_get_state(struct dmub_psr *dmub, enum dc_psr_state *state)
> @@ -90,7 +90,7 @@ static void dmub_psr_get_state(struct dmub_psr *dmub, enum dc_psr_state *state)
>         *state = convert_psr_state(raw_state);
>  }
>
> -/**
> +/*
>   * Set PSR version.
>   */
>  static bool dmub_psr_set_version(struct dmub_psr *dmub, struct dc_stream_state *stream)
> @@ -121,7 +121,7 @@ static bool dmub_psr_set_version(struct dmub_psr *dmub, struct dc_stream_state *
>         return true;
>  }
>
> -/**
> +/*
>   * Enable/Disable PSR.
>   */
>  static void dmub_psr_enable(struct dmub_psr *dmub, bool enable, bool wait)
> @@ -170,7 +170,7 @@ static void dmub_psr_enable(struct dmub_psr *dmub, bool enable, bool wait)
>         }
>  }
>
> -/**
> +/*
>   * Set PSR level.
>   */
>  static void dmub_psr_set_level(struct dmub_psr *dmub, uint16_t psr_level)
> @@ -194,7 +194,7 @@ static void dmub_psr_set_level(struct dmub_psr *dmub, uint16_t psr_level)
>         dc_dmub_srv_wait_idle(dc->dmub_srv);
>  }
>
> -/**
> +/*
>   * Setup PSR by programming phy registers and sending psr hw context values to firmware.
>   */
>  static bool dmub_psr_copy_settings(struct dmub_psr *dmub,
> @@ -277,7 +277,7 @@ static bool dmub_psr_copy_settings(struct dmub_psr *dmub,
>         return true;
>  }
>
> -/**
> +/*
>   * Send command to PSR to force static ENTER and ignore all state changes until exit
>   */
>  static void dmub_psr_force_static(struct dmub_psr *dmub)
> @@ -294,7 +294,7 @@ static void dmub_psr_force_static(struct dmub_psr *dmub)
>         dc_dmub_srv_wait_idle(dc->dmub_srv);
>  }
>
> -/**
> +/*
>   * Get PSR residency from firmware.
>   */
>  static void dmub_psr_get_residency(struct dmub_psr *dmub, uint32_t *residency)
> @@ -316,7 +316,7 @@ static const struct dmub_psr_funcs psr_funcs = {
>         .psr_get_residency              = dmub_psr_get_residency,
>  };
>
> -/**
> +/*
>   * Construct PSR object.
>   */
>  static void dmub_psr_construct(struct dmub_psr *psr, struct dc_context *ctx)
> @@ -325,7 +325,7 @@ static void dmub_psr_construct(struct dmub_psr *psr, struct dc_context *ctx)
>         psr->funcs = &psr_funcs;
>  }
>
> -/**
> +/*
>   * Allocate and initialize PSR object.
>   */
>  struct dmub_psr *dmub_psr_create(struct dc_context *ctx)
> @@ -342,7 +342,7 @@ struct dmub_psr *dmub_psr_create(struct dc_context *ctx)
>         return psr;
>  }
>
> -/**
> +/*
>   * Deallocate PSR object.
>   */
>  void dmub_psr_destroy(struct dmub_psr **dmub)
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Powered by blists - more mailing lists