linux-kernel - Re: [PATCH 1/2] pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 10 Jan 2021 01:24:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        linux-gpio@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, konrad.dybcio@...ainline.org,
        marijn.suijten@...ainline.org, martin.botka@...ainline.org,
        phone-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        linus.walleij@...aro.org,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>
Subject: Re: [PATCH 1/2] pinctrl: Add driver for Awinic AW9523/B I2C GPIO
 Expander

Hi AngeloGioacchino,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pinctrl/devel]
[also build test ERROR on v5.11-rc2 next-20210108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/AngeloGioacchino-Del-Regno/Add-Awinic-AW9523-B-I2C-GPIO-Expander-driver/20210109-220525
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: sparc-randconfig-r025-20210110 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9cf5980cd08c30aec01a24e284a0553396a1fa64
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review AngeloGioacchino-Del-Regno/Add-Awinic-AW9523-B-I2C-GPIO-Expander-driver/20210109-220525
        git checkout 9cf5980cd08c30aec01a24e284a0553396a1fa64
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/pinctrl/pinctrl-aw9523.c: In function 'aw9523_pconf_get':
   drivers/pinctrl/pinctrl-aw9523.c:292:11: error: implicit declaration of function 'FIELD_GET'; did you mean 'FOLL_GET'? [-Werror=implicit-function-declaration]
     292 |    val = !FIELD_GET(AW9523_GCR_GPOMD_MASK, val);
         |           ^~~~~~~~~
         |           FOLL_GET
   drivers/pinctrl/pinctrl-aw9523.c: In function 'aw9523_init_irq':
>> drivers/pinctrl/pinctrl-aw9523.c:880:9: error: 'struct gpio_irq_chip' has no member named 'parent_domain'
     880 |  gpioirq->parent_domain = NULL;
         |         ^~
   cc1: some warnings being treated as errors

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for FRAME_POINTER
   Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS || MCOUNT
   Selected by
   - LOCKDEP && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && !MIPS && !PPC && !ARM && !S390 && !MICROBLAZE && !ARC && !X86
   - FAULT_INJECTION_STACKTRACE_FILTER && FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT && !X86_64 && !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86


vim +880 drivers/pinctrl/pinctrl-aw9523.c

   832	
   833	static int aw9523_init_irq(struct aw9523 *awi, int irq)
   834	{
   835		struct device *dev = awi->dev;
   836		struct gpio_irq_chip *gpioirq;
   837		struct irq_chip *irqchip;
   838		int i, ret;
   839	
   840		if (!device_property_read_bool(dev, "interrupt-controller"))
   841			return 0;
   842	
   843		irqchip = devm_kzalloc(dev, sizeof(*irqchip), GFP_KERNEL);
   844		if (!irqchip)
   845			return -ENOMEM;
   846	
   847		awi->irq = devm_kzalloc(dev, sizeof(*awi->irq), GFP_KERNEL);
   848		if (!awi->irq)
   849			return -ENOMEM;
   850	
   851		irqchip->name = devm_kstrdup(dev, dev_name(dev), GFP_KERNEL);
   852		if (!irqchip->name)
   853			return -ENOMEM;
   854	
   855		irqchip->irq_mask = aw9523_irq_mask;
   856		irqchip->irq_unmask = aw9523_irq_unmask;
   857		irqchip->irq_bus_lock = aw9523_irq_bus_lock;
   858		irqchip->irq_bus_sync_unlock = aw9523_irq_bus_sync_unlock;
   859		irqchip->irq_set_type = aw9523_gpio_irq_type;
   860	
   861		for (i = 0; i < AW9523_NUM_PORTS; i++) {
   862			bitmap_fill(awi->irq->masked[i], AW9523_PINS_PER_PORT);
   863			bitmap_fill(awi->irq->old_masked[i], AW9523_PINS_PER_PORT);
   864		}
   865		awi->irq->irqchip = irqchip;
   866		mutex_init(&awi->irq->lock);
   867	
   868		ret = devm_request_threaded_irq(dev, irq, NULL, aw9523_irq_thread_func,
   869						IRQF_ONESHOT, dev_name(dev), awi);
   870		if (ret) {
   871			dev_err(dev, "Failed to request irq %d\n", irq);
   872			return ret;
   873		}
   874	
   875		gpioirq = &awi->gpio.irq;
   876		gpioirq->chip = irqchip;
   877		gpioirq->parent_handler = NULL;
   878		gpioirq->num_parents = 0;
   879		gpioirq->parents = NULL;
 > 880		gpioirq->parent_domain = NULL;
   881		gpioirq->default_type = IRQ_TYPE_NONE;
   882		gpioirq->handler = handle_simple_irq;
   883		gpioirq->threaded = true;
   884		gpioirq->first = 0;
   885	
   886		return 0;
   887	}
   888	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (20788 bytes)