linux-kernel - [RFC] removing explicit #define DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c1f4416f-95aa-0c9e-1077-182b0922c88f@redhat.com>
Date:   Sat, 9 Jan 2021 14:28:40 -0800
From:   Tom Rix <trix@...hat.com>
To:     LKML <linux-kernel@...r.kernel.org>, Joe Perches <joe@...ches.com>
Subject: [RFC] removing explicit #define DEBUG

In cleaning up the printf %hh's I have found a number of files

that explicitly do a

#define DEBUG

with no comments or surrounding #ifdef CONFIG_MY_DEBUG_FEATURE/#endif

If I saw this in a review, I would assume this was leftover devel code and nak the review.

Finding and removing are pretty trival, i believe there are only around 10.

I am bringing this up because if the existing code depends on the DEBUG,

ex/ getting lucking with timing, then the change would introduce problems.

Tom