linux-kernel - Re: [PATCH -next] fpga: Use DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 10 Jan 2021 11:07:10 -0800
From:   Moritz Fischer <mdf@...nel.org>
To:     Tom Rix <trix@...hat.com>
Cc:     Zheng Yongjun <zhengyongjun3@...wei.com>, mdf@...nel.org,
        linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] fpga: Use DEFINE_SPINLOCK() for spinlock

On Sat, Jan 09, 2021 at 02:08:53PM -0800, Tom Rix wrote:
> 
> On 12/28/20 5:51 AM, Zheng Yongjun wrote:
> > spinlock can be initialized automatically with DEFINE_SPINLOCK()
> > rather than explicitly calling spin_lock_init().
> >
> > Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> 
> This looks fine.
> 
> Reviewed-by: Tom Rix <trix@...hat.com>
> 
> > ---
> >  drivers/fpga/fpga-bridge.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c
> > index 2deccacc3aa7..e9266b2a357f 100644
> > --- a/drivers/fpga/fpga-bridge.c
> > +++ b/drivers/fpga/fpga-bridge.c
> > @@ -17,7 +17,7 @@ static DEFINE_IDA(fpga_bridge_ida);
> >  static struct class *fpga_bridge_class;
> >  
> >  /* Lock for adding/removing bridges to linked lists*/
> > -static spinlock_t bridge_list_lock;
> > +static DEFINE_SPINLOCK(bridge_list_lock);
> >  
> >  /**
> >   * fpga_bridge_enable - Enable transactions on the bridge
> > @@ -479,8 +479,6 @@ static void fpga_bridge_dev_release(struct device *dev)
> >  
> >  static int __init fpga_bridge_dev_init(void)
> >  {
> > -	spin_lock_init(&bridge_list_lock);
> > -
> >  	fpga_bridge_class = class_create(THIS_MODULE, "fpga_bridge");
> >  	if (IS_ERR(fpga_bridge_class))
> >  		return PTR_ERR(fpga_bridge_class);
> 

Applied,

Thanks