linux-kernel - Re: [PATCH] scripts: mod: fix checkpatch.pl warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b11b1e50-bc2a-0037-1f51-fb69300206b1@infradead.org>
Date:   Sun, 10 Jan 2021 12:33:17 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Dwaipayan Ray <dwaipayanray1@...il.com>, masahiroy@...nel.org,
        michal.lkml@...kovi.net
Cc:     lukas.bulwahn@...il.com,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: mod: fix checkpatch.pl warnings

Hi,

On 1/10/21 10:57 AM, Dwaipayan Ray wrote:
> Fix the following warnings in file2alias reported by
> checkpatch:
> 
> CHECK: spaces preferred around that '*' (ctx:WxV)
> CHECK: spaces preferred around that '+' (ctx:VxV)
> CHECK: spaces preferred around that '-' (ctx:VxV)
> CHECK: spaces preferred around that '&' (ctx:VxV)
> CHECK: braces {} should be used on all arms of this statement
> CHECK: Unbalanced braces around else statement
> CHECK: Alignment should match open parenthesis
> CHECK: Logical continuations should be on the previous line
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> WARNING: Missing a blank line after declarations
> WARNING: please, no spaces at the start of a line
> WARNING: Block comments use a trailing */ on a separate line
> ERROR: spaces required around that '<' (ctx:VxV)
> ERROR: spaces required around that '=' (ctx:VxV)
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space prohibited before that close parenthesis ')'
> ERROR: code indent should use tabs where possible
> ERROR: "(foo*)" should be "(foo *)"
> 
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@...il.com>
> ---
> 
> Note: The patch is compile tested only

Couldn't you at least do a kernel build that builds some
loadable kernel modules?

Also you could/should tell us if the before and after .o file
is the same and if not, why not.

> ll file2alias*
-rw-r--r-- 1 rdunlap users 39536 Jan 10 12:10 file2alias.o
-rw-r--r-- 1 rdunlap users 39536 Jan  8 10:06 file2alias.o.b4

> cmp file2alias*
>

Yes, they are the same.
 
>  scripts/mod/file2alias.c | 156 +++++++++++++++++++++------------------
>  1 file changed, 83 insertions(+), 73 deletions(-)


Looks OK to me.

Acked-by: Randy Dunlap <rdunlap@...radead.org>

-- 
~Randy