linux-kernel - Re: [PATCH v5 09/15] lib/test_printf.c: Use helper function to unwind array of software

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <X/riDXHahRAXCQXC@pendragon.ideasonboard.com>
Date:   Sun, 10 Jan 2021 13:16:29 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Daniel Scally <djrscally@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "yong.zhi@...el.com" <yong.zhi@...el.com>,
        "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
        "bingbu.cao@...el.com" <bingbu.cao@...el.com>,
        "tian.shu.qiu@...el.com" <tian.shu.qiu@...el.com>,
        "robert.moore@...el.com" <robert.moore@...el.com>,
        "erik.kaneda@...el.com" <erik.kaneda@...el.com>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "linux@...musvillemoes.dk" <linux@...musvillemoes.dk>,
        "laurent.pinchart+renesas@...asonboard.com" 
        <laurent.pinchart+renesas@...asonboard.com>,
        "jacopo+renesas@...ndi.org" <jacopo+renesas@...ndi.org>,
        "kieran.bingham+renesas@...asonboard.com" 
        <kieran.bingham+renesas@...asonboard.com>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "m.felsch@...gutronix.de" <m.felsch@...gutronix.de>,
        "niklas.soderlund+renesas@...natech.se" 
        <niklas.soderlund+renesas@...natech.se>,
        "prabhakar.mahadev-lad.rj@...renesas.com" 
        <prabhakar.mahadev-lad.rj@...renesas.com>,
        "slongerbeam@...il.com" <slongerbeam@...il.com>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH v5 09/15] lib/test_printf.c: Use helper function to
 unwind array of software_nodes

Hi Andy,

On Sat, Jan 09, 2021 at 11:07:33AM +0200, Andy Shevchenko wrote:
> On Saturday, January 9, 2021, Laurent Pinchart wrote:
> 
> > Hi Peter, Steven and Sergey,
> >
> > Could you please let us know if you're fine with this patch getting
> > merged in v5.12 through the linux-media tree ? The cover letter contains
> > additional details (in a nutshell, this is a cross-tree series and we
> > would like to avoid topic branches if possible).
> 
> There is already a tag by Petr.

I saw that, but looking at the corresponding e-mail, there was no clear
acknowledgement that we could merge this patch through a different tree.

> > On Thu, Jan 07, 2021 at 01:28:32PM +0000, Daniel Scally wrote:
> > > Use the software_node_unregister_nodes() helper function to unwind this
> > > array in a cleaner way.
> > >
> > > Acked-by: Petr Mladek <pmladek@...e.com>
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> > > Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > Signed-off-by: Daniel Scally <djrscally@...il.com>
> > > ---
> > > Changes in v5:
> > >
> > >       - None
> > >
> > >  lib/test_printf.c | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/lib/test_printf.c b/lib/test_printf.c
> > > index 7ac87f18a10f..7d60f24240a4 100644
> > > --- a/lib/test_printf.c
> > > +++ b/lib/test_printf.c
> > > @@ -644,9 +644,7 @@ static void __init fwnode_pointer(void)
> > >       test(second_name, "%pfwP", software_node_fwnode(&softnodes[1]));
> > >       test(third_name, "%pfwP", software_node_fwnode(&softnodes[2]));
> > >
> > > -     software_node_unregister(&softnodes[2]);
> > > -     software_node_unregister(&softnodes[1]);
> > > -     software_node_unregister(&softnodes[0]);
> > > +     software_node_unregister_nodes(softnodes);
> > >  }
> > >
> > >  static void __init

-- 
Regards,

Laurent Pinchart