linux-kernel - Re: [PATCH v2 1/3] mm: Cleanup faultaround and finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210111142718.GC7642@willie-the-truck>
Date:   Mon, 11 Jan 2021 14:27:19 +0000
From:   Will Deacon <will@...nel.org>
To:     "Kirill A. Shutemov" <kirill@...temov.name>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-arm-kernel@...ts.infradead.org,
        Catalin Marinas <catalin.marinas@....com>,
        Jan Kara <jack@...e.cz>, Minchan Kim <minchan@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Vinayak Menon <vinmenon@...eaurora.org>,
        Hugh Dickins <hughd@...gle.com>, kernel-team@...roid.com
Subject: Re: [PATCH v2 1/3] mm: Cleanup faultaround and finish_fault()
 codepaths

On Mon, Jan 11, 2021 at 05:26:20PM +0300, Kirill A. Shutemov wrote:
> On Fri, Jan 08, 2021 at 05:15:15PM +0000, Will Deacon wrote:
> > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > index ecdf8a8cd6ae..801dd99f733c 100644
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> > @@ -542,8 +542,8 @@ struct vm_fault {
> >  					 * is not NULL, otherwise pmd.
> >  					 */
> >  	pgtable_t prealloc_pte;		/* Pre-allocated pte page table.
> > -					 * vm_ops->map_pages() calls
> > -					 * alloc_set_pte() from atomic context.
> > +					 * vm_ops->map_pages() sets up a page
> > +					 * table from from atomic context.
> >  					 * do_fault_around() pre-allocates
> >  					 * page table to avoid allocation from
> >  					 * atomic context.
> 
> The typo Matthew has pointed out:
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index d3d4e307fa09..358fc8616d8b 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -535,7 +535,7 @@ struct vm_fault {
>  					 */
>  	pgtable_t prealloc_pte;		/* Pre-allocated pte page table.
>  					 * vm_ops->map_pages() sets up a page
> -					 * table from from atomic context.
> +					 * table from atomic context.
>  					 * do_fault_around() pre-allocates
>  					 * page table to avoid allocation from
>  					 * atomic context.

Cheers, fixed locally and will include for v3!

Will