linux-kernel - Re: [PATCH] mfd: mt6360: Fix MFD cell names and compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <392f08b4-0e46-3ba3-2515-640a05accbcb@suse.com>
Date:   Mon, 11 Jan 2021 15:38:57 +0100
From:   Matthias Brugger <mbrugger@...e.com>
To:     Gene Chen <gene.chen.richtek@...il.com>, matthias.bgg@...nel.org
CC:     Lee Jones <lee.jones@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Gene Chen <gene_chen@...htek.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        ChiYuan Huang <cy_huang@...htek.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH] mfd: mt6360: Fix MFD cell names and compatibles



On 11/01/2021 14:05, Gene Chen wrote:
> Hi Lee,
> 
> This change exists in [PATCH v7 03/11] mfd: mt6360: Indicate sub-dev
> compatible name by using "-".
> Does patch v7 also merge together to mfd-next?
> 

once again, please don't top-post.

Sorry I didn't saw this patch. Looks good to me, so please ignore this patch mine.

Regards,
Matthias

> <matthias.bgg@...nel.org> 於 2021年1月11日 週一 下午8:35寫道：
>>
>> From: Matthias Brugger <mbrugger@...e.com>
>>
>> MFD cell names and compatibles use '_' instead of '-', which is common
>> practice for names and the standard for DT compatibles.
>> This will also fix the probing for the drivers already implemented
>> (mt6360-adc and mt6360-tcpc).
>>
>> Fixes: 7edd363421da ("mfd: Add support for PMIC MT6360")
>> Fixes: 1f4877218f7e ("iio: adc: mt6360: Add ADC driver for MT6360")
>> Fixes: e1aefcdd394f ("usb typec: mt6360: Add support for mt6360 Type-C driver")
>> Signed-off-by: Matthias Brugger <mbrugger@...e.com>
>>
>> ---
>>
>>  drivers/mfd/mt6360-core.c | 24 ++++++++++++------------
>>  1 file changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
>> index 4661c1b29a72..14e649ffe50f 100644
>> --- a/drivers/mfd/mt6360-core.c
>> +++ b/drivers/mfd/mt6360-core.c
>> @@ -292,18 +292,18 @@ static const struct resource mt6360_ldo_resources[] = {
>>  };
>>
>>  static const struct mfd_cell mt6360_devs[] = {
>> -       OF_MFD_CELL("mt6360_adc", mt6360_adc_resources,
>> -                   NULL, 0, 0, "mediatek,mt6360_adc"),
>> -       OF_MFD_CELL("mt6360_chg", mt6360_chg_resources,
>> -                   NULL, 0, 0, "mediatek,mt6360_chg"),
>> -       OF_MFD_CELL("mt6360_led", mt6360_led_resources,
>> -                   NULL, 0, 0, "mediatek,mt6360_led"),
>> -       OF_MFD_CELL("mt6360_pmic", mt6360_pmic_resources,
>> -                   NULL, 0, 0, "mediatek,mt6360_pmic"),
>> -       OF_MFD_CELL("mt6360_ldo", mt6360_ldo_resources,
>> -                   NULL, 0, 0, "mediatek,mt6360_ldo"),
>> -       OF_MFD_CELL("mt6360_tcpc", NULL,
>> -                   NULL, 0, 0, "mediatek,mt6360_tcpc"),
>> +       OF_MFD_CELL("mt6360-adc", mt6360_adc_resources,
>> +                   NULL, 0, 0, "mediatek,mt6360-adc"),
>> +       OF_MFD_CELL("mt6360-chg", mt6360_chg_resources,
>> +                   NULL, 0, 0, "mediatek,mt6360-chg"),
>> +       OF_MFD_CELL("mt6360-led", mt6360_led_resources,
>> +                   NULL, 0, 0, "mediatek,mt6360-led"),
>> +       OF_MFD_CELL("mt6360-pmic", mt6360_pmic_resources,
>> +                   NULL, 0, 0, "mediatek,mt6360-pmic"),
>> +       OF_MFD_CELL("mt6360-ldo", mt6360_ldo_resources,
>> +                   NULL, 0, 0, "mediatek,mt6360-ldo"),
>> +       OF_MFD_CELL("mt6360-tcpc", NULL,
>> +                   NULL, 0, 0, "mediatek,mt6360-tcpc"),
>>  };
>>
>>  static const unsigned short mt6360_slave_addr[MT6360_SLAVE_MAX] = {
>> --
>> 2.29.2
>>
>