linux-kernel - Re: [PATCH v2 1/3] regulator: mt6360: Add OF match table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a82ba3bd-2ca0-f0cd-b715-a59b57284c1b@suse.com>
Date:   Mon, 11 Jan 2021 15:42:45 +0100
From:   Matthias Brugger <mbrugger@...e.com>
To:     gene_chen(陳俊宇) <gene_chen@...htek.com>,
        "matthias.bgg@...nel.org" <matthias.bgg@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
CC:     Hsin-Hsiung Wang <hsin-hsiung.wang@...iatek.com>,
        Axel Lin <axel.lin@...ics.com>,
        Chen Zhong <chen.zhong@...iatek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Subject: Re: [PATCH v2 1/3] regulator: mt6360: Add OF match table



On 11/01/2021 03:18, gene_chen(陳俊宇) wrote:
> [ Internal Use - External ]
> 
> Hi Matthias,
> 
> I discussed OF match table with Mark in previous mail in our PATCH v3,
> MFD should just instantiate the platform device.
> 
>> Mark Brown <broonie@...nel.org> 於 2020年8月20日 週四 下午7:45寫道：
> 
>>> This device only exists in the context of a single parent device, there
>>> should be no need for a compatible string here - this is just a detail
>>> of how Linux does things.  The MFD should just instntiate the platform
>>> device.
> 
>> Trying to autoload module without of_id_table will cause run-time error:
>> ueventd: LoadWithAliases was unable to load
>> of:NregulatorT(null)Cmediatek,mt6360-regulator
> 
> You shouldn't have this described in the device tree at all, like I say
> the MFD should just instantiate the platform device.
> 

Well with the patch you send to enable regulators [1]  you use OF_MFD_CELL. So
my understanding is, if you don't provide an of_match_table in the regulator
driver, the loading via udev is broken (like you mentioned in the cite from an
older email).

Regards,
Matthias

[1]
https://lore.kernel.org/linux-mediatek/1605177598-23501-5-git-send-email-gene.chen.richtek@gmail.com/

>> -----Original Message-----
>> From: matthias.bgg@...nel.org <matthias.bgg@...nel.org>
>> Sent: Saturday, January 9, 2021 7:26 PM
>> To: Liam Girdwood <lgirdwood@...il.com>; Mark Brown
>> <broonie@...nel.org>
>> Cc: Hsin-Hsiung Wang <hsin-hsiung.wang@...iatek.com>; Axel Lin
>> <axel.lin@...ics.com>; Chen Zhong <chen.zhong@...iatek.com>;
>> gene_chen(陳俊宇) <gene_chen@...htek.com>; linux-kernel@...r.kernel.org;
>> linux-mediatek@...ts.infradead.org; linux-arm-kernel@...ts.infradead.org;
>> Matthias Brugger <matthias.bgg@...il.com>; Matti Vaittinen
>> <matti.vaittinen@...rohmeurope.com>; Matthias Brugger
>> <mbrugger@...e.com>
>> Subject: [PATCH v2 1/3] regulator: mt6360: Add OF match table
>>
>> From: Matthias Brugger <mbrugger@...e.com>
>>
>> Binding documentation mentions that a compatible is required for the
>> MT6360 device node, but the driver doesn't provide a OF match table.
>>
>> Fixes: d321571d5e4c ("regulator: mt6360: Add support for MT6360 regulator")
>> Signed-off-by: Matthias Brugger <mbrugger@...e.com>
>>
>> ---
>>
>> Changes in v2:
>> - check for CONFIG_OF
>> - add Fixes tag
>>
>>  drivers/regulator/mt6360-regulator.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/regulator/mt6360-regulator.c
>> b/drivers/regulator/mt6360-regulator.c
>> index 15308ee29c13..f7b2514feabf 100644
>> --- a/drivers/regulator/mt6360-regulator.c
>> +++ b/drivers/regulator/mt6360-regulator.c
>> @@ -445,9 +445,18 @@ static const struct platform_device_id
>> mt6360_regulator_id_table[] = {  };  MODULE_DEVICE_TABLE(platform,
>> mt6360_regulator_id_table);
>>
>> +#ifdef CONFIG_OF
>> +static const struct of_device_id mt6360_of_match[] = {
>> +{ .compatible = "mediatek,mt6360-regulator", },
>> +{ /* sentinel */ },
>> +};
>> +MODULE_DEVICE_TABLE(of, mt6360_of_match); #endif
>> +
>>  static struct platform_driver mt6360_regulator_driver = {
>>  .driver = {
>>  .name = "mt6360-regulator",
>> +.of_match_table = of_match_ptr(mt6360_of_match),
>>  },
>>  .probe = mt6360_regulator_probe,
>>  .id_table = mt6360_regulator_id_table,
>> --
>> 2.29.2
> ************* Email Confidentiality Notice ********************
> 
> The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!
>