linux-kernel - Re: [RFC PATCH v2] selinux: security: Move selinux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afa0b8674f87c3cac17bf725c826d37e@codeaurora.org>
Date:   Mon, 11 Jan 2021 11:55:28 +0530
From:   pnagar@...eaurora.org
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>, jmorris@...ei.org, serge@...lyn.com,
        paul@...l-moore.com, stephen.smalley.work@...il.com,
        eparis@...isplace.org,
        linux-security-module <linux-security-module@...r.kernel.org>,
        selinux@...r.kernel.org, linux-arch <linux-arch@...r.kernel.org>,
        psodagud@...eaurora.org, nmardana@...eaurora.org,
        dsule@...eaurora.org, Joe Perches <joe@...ches.com>,
        Miguel Ojeda <ojeda@...nel.org>,
        Nick Desaulniers <ndesaulniers@...ogle.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v2] selinux: security: Move selinux_state to a
 separate page

On 2021-01-08 20:55, Miguel Ojeda wrote:
> On Fri, Jan 8, 2021 at 10:52 AM Preeti Nagar <pnagar@...eaurora.org> 
> wrote:
>> 
>> We want to seek your suggestions and comments on the idea and the 
>> changes
>> in the patch.
> 
> Not sure why I was Cc'd, but I have a quick comment nevertheless.
> 
>> +#ifdef CONFIG_SECURITY_RTIC
>> +struct selinux_state selinux_state __rticdata;
>> +#else
>>  struct selinux_state selinux_state;
>> +#endif
> 
> If you define an empty __rticdata for the !CONFIG case, then we don't
> need #ifdefs for uses like this.
> 
> Cheers,
> Miguel
Thank you for the review! Will update this change in the next version of 
the patch soon.

Thanks,
Preeti