linux-kernel - Re: [PATCH] i2c: tegra-bpmp: ignore DMA safe buffer flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3a7037c-4568-dcd3-3e03-d8031cc749b2@kapsi.fi>
Date:   Mon, 11 Jan 2021 17:49:23 +0200
From:   Mikko Perttunen <cyndis@...si.fi>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>,
        Mikko Perttunen <mperttunen@...dia.com>,
        thierry.reding@...il.com, jonathanh@...dia.com
Cc:     talho@...dia.com, linux-i2c@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        Muhammed Fazal <mfazale@...dia.com>, stable@...r.kernel.org
Subject: Re: [PATCH] i2c: tegra-bpmp: ignore DMA safe buffer flag

On 1/11/21 5:04 PM, Ben Dooks wrote:
> On 11/01/2021 14:27, Mikko Perttunen wrote:
>> From: Muhammed Fazal <mfazale@...dia.com>
>>
>> Ignore I2C_M_DMA_SAFE flag as it does not make a difference
>> for bpmp-i2c, but causes -EINVAL to be returned for valid
>> transactions.
>>
>> Signed-off-by: Muhammed Fazal <mfazale@...dia.com>
>> Cc: stable@...r.kernel.org # v4.19+
>> Signed-off-by: Mikko Perttunen <mperttunen@...dia.com>
>> ---
>> This fixes failures seen with PMIC probing tools on
>> Tegra186+ boards.
>>
>>   drivers/i2c/busses/i2c-tegra-bpmp.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/i2c/busses/i2c-tegra-bpmp.c 
>> b/drivers/i2c/busses/i2c-tegra-bpmp.c
>> index ec7a7e917edd..998d4b21fb59 100644
>> --- a/drivers/i2c/busses/i2c-tegra-bpmp.c
>> +++ b/drivers/i2c/busses/i2c-tegra-bpmp.c
>> @@ -80,6 +80,9 @@ static int tegra_bpmp_xlate_flags(u16 flags, u16 *out)
>>           flags &= ~I2C_M_RECV_LEN;
>>       }
>> +    if (flags & I2C_M_DMA_SAFE)
>> +        flags &= ~I2C_M_DMA_SAFE;
>> +
> 
> Just a comment, you can do without the test here.
> Just doing this would have been fine:
> 
>      flags &= ~I2C_M_DMA_SAFE;
> 
> 
> 

Yep, I'll send a v2.

thanks,
Mikko