linux-kernel - Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32b6ba61-91a8-ada3-1c8f-0e85d330f27e@gmail.com>
Date:   Mon, 11 Jan 2021 09:21:11 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     YANG LI <abaci-bugfix@...ux.alibaba.com>, kdasu.kdev@...il.com,
        bcm-kernel-feedback-list@...adcom.com,
        linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org
Subject: Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison

On 1/11/21 9:05 AM, Mark Brown wrote:
> On Mon, Jan 11, 2021 at 08:41:19AM -0800, Florian Fainelli wrote:
> 
>>> [1/1] spi: spi-bcm-qspi: style: Simplify bool comparison
>>>       commit: 6650ab2a44268af8d24995d28ae199b57b2ebff8
> 
>> I don't think that "style: " is a subject prefix that is used commonly
>> and it certainly should not belong in a commit subject. Mark can you
>> please people at least 10-12 hours to review changes before applying
>> them? This one is trivial except the commit subject does not match
>> previous changes done to this file and it should have been fixed.
> 
> Honestly for super trivial stuff like this I'm not sure it's a useful
> use of anyone's time to police this sort of stuff aggressively, it's
> after the prefixes that matter so I saw it easily and I'm having a hard
> time caring that it happens to be done as a prefix rather than saying
> style somewhere else in the subject.

That sounds fair, however it does look like people who submit trivial
patches are typically the ones that also tend not to follow prior
commits to the same file, and given the patch is trivial, enforcing a
consistent subject sort of offsets the less amount of time spent in
reviewing the patch.

> 
> I will generally hold off for longer with these trivial patches on
> things where I expect to see some review but that's felt a bit patchy
> with the Broadcom drivers.
> 

OK, we will try to be more reactive then, Kamal is in GMT-0500 and I am
GMT-0800 so it make take a bit of time for us to get to our review backlog.

Thanks!
-- 
Florian