linux-kernel - Re: [PATCH 1/2] lib/cmdline: add new function get_option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210111172259.GZ4077@smile.fi.intel.com>
Date:   Mon, 11 Jan 2021 19:22:59 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Wesley Zhao <zhaowei1102@...ndersoft.com>
Cc:     akpm@...ux-foundation.org, keescook@...omium.org,
        tglx@...utronix.de, kerneldev@...smulder.nl, nivedita@...m.mit.edu,
        joe@...ches.com, gpiccoli@...onical.com, aquini@...hat.com,
        gustavoars@...nel.org, ojeda@...nel.org, ndesaulniers@...ogle.com,
        linux-kernel@...r.kernel.org, david@...hat.com,
        dan.j.williams@...el.com, guohanjun@...wei.com,
        mchehab+huawei@...nel.org
Subject: Re: [PATCH 1/2] lib/cmdline: add new function get_option_ull()

On Mon, Jan 11, 2021 at 08:33:17AM -0800, Wesley Zhao wrote:
> From: "Wesley.Zhao" <zhaowei1102@...ndersoft.com>
> 
> In the future we would pass the unsigned long long parameter
> like(0x123456781234) in cmdline on the 64bit platform, so add a new
> option parse function get_option_ull()

No negative numbers?
No test cases?
No user?

Please, address above.

Besides that, consider to deduplicate (like it's done in simple_strto*() family
of functions), so we don't have two implementation that are basically do the
same, only put result to a different type of variable.

-- 
With Best Regards,
Andy Shevchenko