linux-kernel - Re: [PATCH] scsi: libsas and users: Remove notifier indirection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a056f28e-bbdc-1400-83f2-b6d76afd92b9@huawei.com>
Date:   Mon, 11 Jan 2021 17:44:17 +0000
From:   John Garry <john.garry@...wei.com>
To:     "Ahmed S. Darwish" <a.darwish@...utronix.de>
CC:     <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
        <artur.paszkiewicz@...el.com>, <jinpu.wang@...ud.ionos.com>,
        <corbet@....net>, <yanaijie@...wei.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <intel-linux-scu@...el.com>, <linux-doc@...r.kernel.org>
Subject: Re: [PATCH] scsi: libsas and users: Remove notifier indirection

On 11/01/2021 17:41, Ahmed S. Darwish wrote:
> On Tue, Jan 12, 2021 at 01:28:32AM +0800, John Garry wrote:
> ...
>> index a920eced92ec..6a51abdc59ae 100644
>> --- a/drivers/scsi/mvsas/mv_sas.c
>> +++ b/drivers/scsi/mvsas/mv_sas.c
>> @@ -230,7 +230,7 @@ static void mvs_bytes_dmaed(struct mvs_info *mvi, int i)
>>   	}
>>
>>   	sas_ha = mvi->sas;
>> -	sas_ha->notify_phy_event(sas_phy, PHYE_OOB_DONE);
>> +	sas_notify_phy_event(sas_phy, PHYE_OOB_DONE);
>>
> 
> Minor point: "sas_ha" is now not used anywhere; it should be removed.
> .
> 

ah, yes, it can be removed.

BTW, on separate topic, did intel-linux-scu@...el.com bounce for you?

Thanks,
John