lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Jan 2021 19:05:41 +0100 From: Ulf Hansson <ulf.hansson@...aro.org> To: Christophe JAILLET <christophe.jaillet@...adoo.fr> Cc: Jesper Nilsson <jesper.nilsson@...s.com>, Lars Persson <lars.persson@...s.com>, Guennadi Liakhovetski <g.liakhovetski@....de>, Chris Ball <chris@...ntf.net>, linux-arm-kernel@...s.com, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] mmc: usdhi6rol0: Fix a resource leak in the error handling path of the probe On Thu, 17 Dec 2020 at 22:09, Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote: > > A call to 'ausdhi6_dma_release()' to undo a previous call to > 'usdhi6_dma_request()' is missing in the error handling path of the probe > function. > > It is already present in the remove function. > > Fixes: 75fa9ea6e3c0 ("mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller") > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/usdhi6rol0.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c > index e2d5112d809d..615f3d008af1 100644 > --- a/drivers/mmc/host/usdhi6rol0.c > +++ b/drivers/mmc/host/usdhi6rol0.c > @@ -1858,10 +1858,12 @@ static int usdhi6_probe(struct platform_device *pdev) > > ret = mmc_add_host(mmc); > if (ret < 0) > - goto e_clk_off; > + goto e_release_dma; > > return 0; > > +e_release_dma: > + usdhi6_dma_release(host); > e_clk_off: > clk_disable_unprepare(host->clk); > e_free_mmc: > -- > 2.27.0 >
Powered by blists - more mailing lists