linux-kernel - Re: [PATCH] usb/gadget: f_midi: Replace tasklet with work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r1ms0w6a.fsf@kernel.org>
Date:   Mon, 11 Jan 2021 09:28:29 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     Davidlohr Bueso <dave@...olabs.net>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, dave@...olabs.net,
        Takashi Iwai <tiwai@...e.de>, Davidlohr Bueso <dbueso@...e.de>
Subject: Re: [PATCH] usb/gadget: f_midi: Replace tasklet with work


Hi,

Davidlohr Bueso <dave@...olabs.net> writes:
> Currently a tasklet is used to transmit input substream buffer
> data. However, tasklets have long been deprecated as being too
> heavy on the system by running in irq context - and this is not
> a performance critical path. If a higher priority process wants
> to run, it must wait for the tasklet to finish before doing so.
>
> Deferring work to a workqueue and executing in process context
> should be fine considering the callback already does
> f_midi_do_transmit() under the transmit_lock and thus changes in
> semantics are ok regarding concurrency - tasklets being serialized
> against itself.
>
> Cc: Takashi Iwai <tiwai@...e.de>
> Signed-off-by: Davidlohr Bueso <dbueso@...e.de>

Acked-by: Felipe Balbi <balbi@...nel.org>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (858 bytes)