linux-kernel - Re: [PATCH v2 19/34] xlink-core: Add xlink core device tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Jan 2021 13:27:36 -0600
From:   Rob Herring <robh@...nel.org>
To:     mgross@...ux.intel.com
Cc:     markgross@...nel.org, arnd@...db.de, bp@...e.de,
        damien.lemoal@....com, dragan.cvetic@...inx.com,
        gregkh@...uxfoundation.org, corbet@....net,
        leonard.crestez@....com, palmerdabbelt@...gle.com,
        paul.walmsley@...ive.com, peng.fan@....com, shawnguo@...nel.org,
        jassisinghbrar@...il.com, linux-kernel@...r.kernel.org,
        Seamus Kelly <seamus.kelly@...el.com>,
        devicetree@...r.kernel.org,
        Ryan Carnaghi <ryan.r.carnaghi@...el.com>
Subject: Re: [PATCH v2 19/34] xlink-core: Add xlink core device tree bindings

On Fri, Jan 08, 2021 at 01:25:45PM -0800, mgross@...ux.intel.com wrote:
> From: Seamus Kelly <seamus.kelly@...el.com>
> 
> Add device tree bindings for keembay-xlink.
> 
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: devicetree@...r.kernel.org
> Reviewed-by: Mark Gross <mgross@...ux.intel.com>
> Signed-off-by: Seamus Kelly <seamus.kelly@...el.com>
> Signed-off-by: Ryan Carnaghi <ryan.r.carnaghi@...el.com>
> ---
>  .../bindings/misc/intel,keembay-xlink.yaml    | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> 
> diff --git a/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> new file mode 100644
> index 000000000000..89c34018fa04
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (c) Intel Corporation. All rights reserved.
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/misc/intel,keembay-xlink.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Intel Keem Bay xlink
> +
> +maintainers:
> +  - Seamus Kelly <seamus.kelly@...el.com>
> +
> +description: |
> +  The Keem Bay xlink driver enables the communication/control sub-system
> +  for internal and external communications to the Intel Keem Bay SoC.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +        - const: intel,keembay-xlink
> +
> +examples:
> +  - |
> +    xlink {
> +        compatible = "intel,keembay-xlink";
> +    };

A node with a compatible and nothing else is generally a sign of abusing 
DT to instantiate a driver. You don't need DT for that.

Rob