linux-kernel - Re: linux-next: Fixes tag needs some work in the spi tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Jan 2021 02:28:12 +0530
From:   Pratyush Yadav <p.yadav@...com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
CC:     Mark Brown <broonie@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Andy Whitcroft <apw@...onical.com>,
        Joe Perches <joe@...ches.com>
Subject: Re: linux-next: Fixes tag needs some work in the spi tree

+Cc checkpatch.pl maintainers.

On 12/01/21 07:36AM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   2ef0170e9039 ("spi: cadence-quadspi: Fix build warning on 32-bit platforms")
> 
> Fixes tag
> 
>   Fixes: f453f293979f ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Did yu mean
> 
> Fixes: f453f293979f ("spi: cadence-quadspi: Add DTR support")
> 
> or
> 
> Fixes: 0920a32cf6f2 ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")

I meant this one. My mistake. Copied the wrong hash. Any way to fix this 
now?

This check should probably be added in checkpatch.pl so mistakes like 
this can be avoided in the future.

-- 
Regards,
Pratyush Yadav
Texas Instruments India