linux-kernel - Re: [PATCH] drm/hisilicon: Use drm_crtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <adf7a7cb-ac91-5d46-6faf-f77362fa515c@suse.de>
Date:   Mon, 11 Jan 2021 08:49:35 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Tian Tao <tiantao6@...ilicon.com>, airlied@...ux.ie,
        daniel@...ll.ch, kraxel@...hat.com, alexander.deucher@....com,
        tglx@...utronix.de, dri-devel@...ts.freedesktop.org,
        xinliang.liu@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/hisilicon: Use drm_crtc_mask()

Hi

Am 11.01.21 um 04:30 schrieb Tian Tao:
> Use drm_crtc_mask() where appropriate.
> 
> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>

Looks like the right thing to do.

Acked-by: Thomas Zimmermann <tzimmermann@...e.de>

Best regards
Thomas

> ---
>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> index c76f996..1c5f2fa 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> @@ -96,6 +96,7 @@ int hibmc_vdac_init(struct hibmc_drm_private *priv)
>   	struct drm_device *dev = &priv->dev;
>   	struct hibmc_connector *hibmc_connector = &priv->connector;
>   	struct drm_encoder *encoder = &priv->encoder;
> +	struct drm_crtc *crtc = &priv->crtc;
>   	struct drm_connector *connector = &hibmc_connector->base;
>   	int ret;
>   
> @@ -105,7 +106,7 @@ int hibmc_vdac_init(struct hibmc_drm_private *priv)
>   		return ret;
>   	}
>   
> -	encoder->possible_crtcs = 0x1;
> +	encoder->possible_crtcs = drm_crtc_mask(crtc);
>   	ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_DAC);
>   	if (ret) {
>   		drm_err(dev, "failed to init encoder: %d\n", ret);
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer



Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)