linux-kernel - Re: [PATCH] clk: imx: fix Kconfig warning for i.MX SCU clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Jan 2021 09:41:11 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Dong Aisheng <aisheng.dong@....com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Arnd Bergmann <arnd@...db.de>,
        Anders Roxell <anders.roxell@...aro.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Anson Huang <Anson.Huang@....com>, Peng Fan <peng.fan@....com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: imx: fix Kconfig warning for i.MX SCU clk

On Wed, Dec 30, 2020 at 04:52:25PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> A previous patch introduced a harmless randconfig warning:
> 
> WARNING: unmet direct dependencies detected for MXC_CLK_SCU
>   Depends on [n]: COMMON_CLK [=y] && ARCH_MXC [=n] && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
>   Selected by [m]:
>   - CLK_IMX8QXP [=m] && COMMON_CLK [=y] && (ARCH_MXC [=n] && ARM64 [=y] || COMPILE_TEST [=y]) && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
> 
> Since the symbol is now hidden and only selected by other symbols,
> just remove the dependencies and require the other drivers to
> get it right.
> 
> Fixes: 6247e31b7530 ("clk: imx: scu: fix MXC_CLK_SCU module build break")
> Reported-by: Anders Roxell <anders.roxell@...aro.org>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Looks good to me.

Stephen, I assume that you will pick it up as a material for 5.11-rc.

Shawn