linux-kernel - Re: [PATCH v3 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Jan 2021 10:16:03 +0100
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Baoquan He <bhe@...hat.com>
Cc:     HAGIO KAZUHITO(萩尾　一仁) 
        <k-hagio-ab@....com>, "lijiang@...hat.com" <lijiang@...hat.com>,
        "kexec@...ts.infradead.org" <kexec@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ktkhai@...tuozzo.com" <ktkhai@...tuozzo.com>,
        "ebiederm@...ssion.com" <ebiederm@...ssion.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "dyoung@...hat.com" <dyoung@...hat.com>,
        "christian.brauner@...ntu.com" <christian.brauner@...ntu.com>,
        "vgoyal@...hat.com" <vgoyal@...hat.com>,
        "keescook@...omium.org" <keescook@...omium.org>,
        Alexander Egorenkov <egorenar@...ux.ibm.com>
Subject: Re: [PATCH v3 1/1] kdump: append uts_namespace.name offset to
 VMCOREINFO

On Fri, Jan 08, 2021 at 06:22:24PM +0800, Baoquan He wrote:
> On 01/08/21 at 10:07am, HAGIO KAZUHITO(萩尾 一仁) wrote:
> > Hi Baoquan,
> > 
> > -----Original Message-----
> > > On 09/30/20 at 12:23pm, Alexander Egorenkov wrote:
> > > > The offset of the field 'init_uts_ns.name' has changed
> > > > since commit 9a56493f6942 ("uts: Use generic ns_common::count").
> > > 
> > > This patch is merged into 5.11-rc1, but we met the makedumpfile failure
> > > of kdump test case in 5.10.0 kernel. Should affect 5.9 too since
> > > commit 9a56493f6942 is merged into 5.9-rc2.
> > 
> > Hmm, commit 9a56493f6942 should have been merged into 5.11-rc1
> > together with commit ca4a9241cc5e.
> 
> Checked on master branch of mainline kernel, commit 9a56493f6942 is in
> 5.9-rc1.


No, that commit is in 5.11-rc1, not 5.9-rc1:
	$ git describe --contains 9a56493f6942
	v5.11-rc1~182^2~9

> commit ca4a9241cc5e is merged into 5.11-rc1.
> 
> commit 9a56493f6942c0e2df1579986128721da96e00d8
> Author: Kirill Tkhai <ktkhai@...tuozzo.com>
> Date:   Mon Aug 3 13:16:21 2020 +0300
> 
>     uts: Use generic ns_common::count
> 
> 
> commit ca4a9241cc5e718de86a34afd41972869546a5e3
> Author: Alexander Egorenkov <egorenar@...ux.ibm.com>
> Date:   Tue Dec 15 20:45:31 2020 -0800
> 
>     kdump: append uts_namespace.name offset to VMCOREINFO


Are you all sure this is needed in 5.10.y?

thanks,

greg k-h