linux-kernel - [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 11 Jan 2021 17:54:48 +0800
From:   YANG LI <abaci-bugfix@...ux.alibaba.com>
To:     kdasu.kdev@...il.com
Cc:     bcm-kernel-feedback-list@...adcom.com, broonie@...nel.org,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        YANG LI <abaci-bugfix@...ux.alibaba.com>
Subject: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison

Fix the following coccicheck warning:
./drivers/spi/spi-bcm-qspi.c:884:5-34:
WARNING: Comparison to bool

Signed-off-by: YANG LI <abaci-bugfix@...ux.alibaba.com>
Reported-by: Abaci Robot<abaci@...ux.alibaba.com>
---
 drivers/spi/spi-bcm-qspi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c
index c028446..d28d7bd 100644
--- a/drivers/spi/spi-bcm-qspi.c
+++ b/drivers/spi/spi-bcm-qspi.c
@@ -881,7 +881,7 @@ static int bcm_qspi_bspi_exec_mem_op(struct spi_device *spi,
 	 * when using flex mode we need to send
 	 * the upper address byte to bspi
 	 */
-	if (bcm_qspi_bspi_ver_three(qspi) == false) {
+	if (!bcm_qspi_bspi_ver_three(qspi)) {
 		addr = from & 0xff000000;
 		bcm_qspi_write(qspi, BSPI,
 			       BSPI_BSPI_FLASH_UPPER_ADDR_BYTE, addr);
@@ -892,7 +892,7 @@ static int bcm_qspi_bspi_exec_mem_op(struct spi_device *spi,
 	else
 		addr = from & 0x00ffffff;
 
-	if (bcm_qspi_bspi_ver_three(qspi) == true)
+	if (bcm_qspi_bspi_ver_three(qspi))
 		addr = (addr + 0xc00000) & 0xffffff;
 
 	/*
-- 
1.8.3.1