linux-kernel - Re: [PATCH] dtc: Allow overlays to have .dtbo extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210111105611.GD3051@yekko.fritz.box>
Date:   Mon, 11 Jan 2021 21:56:11 +1100
From:   David Gibson <david@...son.dropbear.id.au>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     devicetree-compiler@...r.kernel.org,
        Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
        Frank Rowand <frowand.list@...il.com>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Bill Mills <bill.mills@...aro.org>, anmar.oueja@...aro.org
Subject: Re: [PATCH] dtc: Allow overlays to have .dtbo extension

On Wed, Jan 06, 2021 at 03:26:08PM +0530, Viresh Kumar wrote:
> Allow the overlays to have .dtbo extension instead of just .dtb. This
> allows them to be identified easily by tools as well as humans.
> 
> Allow the dtbo outform in dtc.c for the same.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

Seems reasonable.  Applied.

> 
> ---
> Hello,
> 
> This was earlier posted for the Linux Kernel and here is the thread
> where Rob gave his feedback:
> 
> https://lore.kernel.org/lkml/CAL_Jsq+0dL=LHo8r9mY_weBP_bQ97UOBnt596J3JoVHwGNinHA@mail.gmail.com/
> ---
>  dtc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/dtc.c b/dtc.c
> index bdb3f5945699..838c5df96c00 100644
> --- a/dtc.c
> +++ b/dtc.c
> @@ -122,6 +122,8 @@ static const char *guess_type_by_name(const char *fname, const char *fallback)
>  		return "dts";
>  	if (!strcasecmp(s, ".yaml"))
>  		return "yaml";
> +	if (!strcasecmp(s, ".dtbo"))
> +		return "dtb";
>  	if (!strcasecmp(s, ".dtb"))
>  		return "dtb";
>  	return fallback;
> @@ -357,6 +359,8 @@ int main(int argc, char *argv[])
>  #endif
>  	} else if (streq(outform, "dtb")) {
>  		dt_to_blob(outf, dti, outversion);
> +	} else if (streq(outform, "dtbo")) {
> +		dt_to_blob(outf, dti, outversion);
>  	} else if (streq(outform, "asm")) {
>  		dt_to_asm(outf, dti, outversion);
>  	} else if (streq(outform, "null")) {

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)