linux-kernel - Re: [PATCH v3 1/4] lib: vsprintf: scanf: Negative number must have field width

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210111111409.GW4077@smile.fi.intel.com>
Date:   Mon, 11 Jan 2021 13:14:09 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc:     Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Shuah Khan <shuah@...nel.org>, patches@...nsource.cirrus.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH v3 1/4] lib: vsprintf: scanf: Negative number must have
 field width > 1

On Mon, Jan 11, 2021 at 10:43:17AM +0000, Richard Fitzgerald wrote:
> On 11/01/2021 10:39, Richard Fitzgerald wrote:
> > On 11/01/2021 10:36, Andy Shevchenko wrote:
> > > On Mon, Jan 11, 2021 at 12:28 PM Petr Mladek <pmladek@...e.com> wrote:
> > > > 
> > > > Sigh, I have just realized that Andy and Rasmus, the other
> > > > vsprintf maintainers and reviewers, were not in CC.
> > > > I am sorry for not noticing this earlier.
> > > > 
> > > > The patchset is ready for 5.12 from my POV.
> > > 
> > > Thanks, Petr!
> > > 
> > > I have one question, do we have a test case for that? If not, I prefer
> > > defer until a test case will be provided.
> > > 
> > 
> > See patch 3, numbers_prefix_overflow()
> 
> Sorry, I missed you off the original mailing so you won't have
> seen the other patches.
> Patch 3 with the test cases is here:
> https://lore.kernel.org/lkml/X%2FwnoJLEt0zQskDU@alley/T/#mf2ffba20126e438bea7af171bc78fdbebdb40027

Good, you did it!
Couple of remarks:
 - free resources in the same function where you allocated them
 - use post increment where it doesn't matter (like total_test)


-- 
With Best Regards,
Andy Shevchenko