linux-kernel - Re: [PATCH] MIPS: OCTEON: fix unreachable code in octeon_irq_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d2ed48b2-2043-a9f1-ea7a-2fb5c4027c57@nokia.com>
Date:   Mon, 11 Jan 2021 12:59:09 +0100
From:   Alexander Sverdlin <alexander.sverdlin@...ia.com>
To:     menglong8.dong@...il.com, paulburton@...nel.org
Cc:     tsbogend@...ha.franken.de, dong.menglong@....com.cn,
        colin.king@...onical.com, gustavo@...eddedor.com,
        ralf@...ux-mips.org, peter.swain@...ium.com,
        aleksey.makarov@...iga.com, lrosenboim@...iumnetworks.com,
        david.daney@...ium.com, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: OCTEON: fix unreachable code in octeon_irq_init_ciu

Hello Menglong!

Thank you for the fix! A small correction below:

On 11/01/2021 12:36, menglong8.dong@...il.com wrote:
> From: Menglong Dong <dong.menglong@....com.cn>
> 
> The type of 'r' in octeon_irq_init_ciu is 'unsigned int', so 'r < 0'
> can't be true.
> 
> Fix this by change the type of 'r' and 'i' from 'unsigned int'
> to 'int'. As 'i' won't be negative, this change works.
> 
> Fixes: 64b139f97c01("MIPS: OCTEON: irq: add CIB and other fixes")

The patch actually fixes my commit 99fbc70f8547
("MIPS: Octeon: irq: Alloc desc before configuring IRQ").
With "Fixes:" tag corrected, you can put my

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...ia.com>

> Signed-off-by: Menglong Dong <dong.menglong@....com.cn>
> ---
>  arch/mips/cavium-octeon/octeon-irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
> index bd47e15d02c7..be5d4afcd30f 100644
> --- a/arch/mips/cavium-octeon/octeon-irq.c
> +++ b/arch/mips/cavium-octeon/octeon-irq.c
> @@ -1444,7 +1444,7 @@ static void octeon_irq_setup_secondary_ciu2(void)
>  static int __init octeon_irq_init_ciu(
>  	struct device_node *ciu_node, struct device_node *parent)
>  {
> -	unsigned int i, r;
> +	int i, r;
>  	struct irq_chip *chip;
>  	struct irq_chip *chip_edge;
>  	struct irq_chip *chip_mbox;
> 

-- 
Best regards,
Alexander Sverdlin.