linux-kernel - Re: [PATCH v2] proc_sysctl: fix oops caused by incorrect command parameters.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ce276a4e-6be2-cb39-6006-a21bced347f8@huawei.com>
Date:   Mon, 11 Jan 2021 11:14:08 +0800
From:   Xiaoming Ni <nixiaoming@...wei.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mcgrof@...nel.org" <mcgrof@...nel.org>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "yzaikin@...gle.com" <yzaikin@...gle.com>,
        "adobriyan@...il.com" <adobriyan@...il.com>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "vbabka@...e.cz" <vbabka@...e.cz>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "mhocko@...e.com" <mhocko@...e.com>,
        "wangle6@...wei.com" <wangle6@...wei.com>
Subject: Re: [PATCH v2] proc_sysctl: fix oops caused by incorrect command
 parameters.

On 2021/1/9 17:10, Andy Shevchenko wrote:
> 
> 
> On Friday, January 8, 2021, Xiaoming Ni <nixiaoming@...wei.com 
> <mailto:nixiaoming@...wei.com>> wrote:
> 
>     The process_sysctl_arg() does not check whether val is empty before
>       invoking strlen(val). If the command line parameter () is incorrectly
>       configured and val is empty, oops is triggered.
> 
>     For example, "hung_task_panic=1" is incorrectly written as
>     "hung_task_panic".
> 
>     log:
> 
> 
> Can you drop redundant (not significant) lines from the log to avoid 
> noisy commit message?
> 
ok,
Thank you for your advice.
I will update it in v3 patch.

Thanks

Xiaoming Ni.