lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Jan 2021 11:27:47 +0800 From: Chen-Yu Tsai <wens@...nel.org> To: Heiko Stübner <heiko@...ech.de> Cc: Johan Jonker <jbx6244@...il.com>, Chen-Yu Tsai <wens@...nel.org>, Rob Herring <robh@...nel.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>, linux-kernel <linux-kernel@...r.kernel.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, devicetree <devicetree@...r.kernel.org> Subject: Re: [PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E On Mon, Jan 11, 2021 at 4:06 AM Heiko Stübner <heiko@...ech.de> wrote: > > Hi, > > Am Sonntag, 10. Januar 2021, 16:37:15 CET schrieb Chen-Yu Tsai: > > > > + vcc_sd: sdmmc-regulator { > > > > + compatible = "regulator-fixed"; > > > > + gpio = <&gpio0 RK_PD6 GPIO_ACTIVE_LOW>; > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&sdmmc0m1_pin>; > > > > > > > + regulator-boot-on; > > > > + regulator-name = "vcc_sd"; > > > > > > regulator-name above other regulator properties > > > > That is actually what I was used to, but some other rockchip dts files > > have all the properties sorted alphabetically. So I stuck with what I > > saw. > > I try to keep it alphabetical except for the exceptions :-D . > > regulator-name is such an exception. Similar to compatibles, the > regulator-name is an entry needed to see if you're at the right node, > so I really like it being the topmost regulator-foo property - just makes > reading easier. > > (same for the compatible first, then regs, interrupts parts, as well > as "status-last") > > But oftentimes, I just fix the ordering when applying - but seem to have > missed this somewhere in those "other Rockchip dts files" ;-) . I was slightly confused. I looked again and yes regulator-name is always the first regulator related property. What's off is that in some cases min/max voltage comes before always-on/boot-on, and in others vice versa. For example in the Rock64 and ROC-RK3328-CC device trees, in the fixed regulators, always-on/boot-on come before min/max voltage, while in the PMIC the other order is used. ChenYu
Powered by blists - more mailing lists