lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 11 Jan 2021 08:29:45 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Martin Kepplinger <martin.kepplinger@...i.sm>
Cc:     robh@...nel.org, festevam@...il.com, kernel@...gutronix.de,
        linux-imx@....com, krzk@...nel.org, kernel@...i.sm,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the
 touchscreen description

On Tue, Dec 22, 2020 at 04:13:45PM +0100, Martin Kepplinger wrote:
> In order for the touchscreen interrupt line to work, describe it properly.
> Otherwise it can work if defaults are ok, but we cannot be sure.
> 
> Fixes: 8f0216b006e5 ("arm64: dts: Add a device tree for the Librem 5 phone")
> Signed-off-by: Martin Kepplinger <martin.kepplinger@...i.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index 55268fc0622e..a60df09d90f7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -459,6 +459,13 @@
>  		>;
>  	};
>  
> +	pinctrl_touch: touchgrp {
> +		fsl,pins = <
> +		/* TP_INT */
> +		MX8MQ_IOMUXC_ENET_RD1_GPIO1_IO27	0x80

Miss indentation for these two lines.

I fixed it up and applied the series.

Shawn

> +		>;
> +	};
> +
>  	pinctrl_typec: typecgrp {
>  		fsl,pins = <
>  			/* TYPEC_MUX_EN */
> @@ -880,6 +887,8 @@
>  	touchscreen@38 {
>  		compatible = "edt,edt-ft5506";
>  		reg = <0x38>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_touch>;
>  		interrupt-parent = <&gpio1>;
>  		interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
>  		touchscreen-size-x = <720>;
> -- 
> 2.20.1
> 

Powered by blists - more mailing lists